[GitHub] rafaelweingartner commented on a change in pull request #2869: Fix some Marvin smoke tests

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2869: Fix some Marvin smoke tests
URL: https://github.com/apache/cloudstack/pull/2869#discussion_r221654869
 
 

 ##########
 File path: test/integration/smoke/test_hostha_kvm.py
 ##########
 @@ -274,9 +274,12 @@ def test_hostha_enable_ha_when_host_in_maintenance(self):
             Tests Enable HA when host is in Maintenance mode, should be Ineligible
         """
         self.logger.debug("Starting test_hostha_enable_ha_when_host_in_maintenance")
-
+        self.logger.debug("Pausing to wait for VMs to have finished starting")
+        time.sleep(300)
 
 Review comment:
   Can't we execute this "sleep" differently? I mean, wouldn't it be better to check the "startVm" job to see if it has finished properly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services