You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2026/10/12 13:47:48 UTC
[PR] [FLINK-40971][parquet] Run ParquetTimestampITCase for all its parameters [flink]
MartijnVisser opened a new pull request, #29463:
URL: https://github.com/apache/flink/pull/29463
## What is the purpose of the change
`ParquetTimestampITCase` never ran its parameterized cases. Its tests are plain `@Test` methods inherited from `FsStreamingSinkITCaseBase`, so `ParameterizedTestExtension` does not apply and each test runs once with `useInt64` false.
## Brief change log
- Use AssertJ in `check()` (hotfix commit)
- Override the four inherited tests as `@TestTemplate` and give the parameter fields their own indices
## Verifying this change
`./mvnw -pl flink-formats/flink-parquet test -Dtest=ParquetTimestampITCase` reports `Tests run: 4` on master and `Tests run: 28` with this change. Breaking `ParquetRowDataWriter` locally (micros written as millis, or `utc-timezone = false` ignored) passes on master and fails here. The timezone case only fails when the JVM zone is not UTC (I used Europe/Amsterdam); I haven't checked which zone CI uses. The class goes from about 10s to about 25s locally.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40971][parquet] Run ParquetTimestampITCase for all its parameters [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29463:
URL: https://github.com/apache/flink/pull/29463#issuecomment-6125903651
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fec020f3e4a90ac7b45f87efa57b7b586def2d6f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fec020f3e4a90ac7b45f87efa57b7b586def2d6f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fec020f3e4a90ac7b45f87efa57b7b586def2d6f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40971][parquet] Run ParquetTimestampITCase for all its parameters [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #29463:
URL: https://github.com/apache/flink/pull/29463#discussion_r4256680493
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java:
##########
@@ -55,16 +56,18 @@
import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.TIMESTAMP_TIME_UNIT;
import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.UTC_TIMEZONE;
import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.WRITE_INT64_TIMESTAMP;
-import static org.junit.Assert.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/** Test int64 timestamp. */
@ExtendWith(ParameterizedTestExtension.class)
Review Comment:
Good point. I'll open a separate ticket to bump to 5.14 (6.x needs Java 17) and keep this PR on ParameterizedTestExtension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40971][parquet] Run ParquetTimestampITCase for all its parameters [flink]
Posted by "raminqaf (via GitHub)" <gi...@apache.org>.
raminqaf commented on code in PR #29463:
URL: https://github.com/apache/flink/pull/29463#discussion_r4256477295
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java:
##########
@@ -55,16 +56,18 @@
import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.TIMESTAMP_TIME_UNIT;
import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.UTC_TIMEZONE;
import static org.apache.flink.formats.parquet.ParquetFileFormatFactory.WRITE_INT64_TIMESTAMP;
-import static org.junit.Assert.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/** Test int64 timestamp. */
@ExtendWith(ParameterizedTestExtension.class)
Review Comment:
FYI Junit 5.13 introduced `@ParametizedClass` https://docs.junit.org/5.14.0/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedClass.html
We are still on 5.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40971][parquet] Run ParquetTimestampITCase for all its parameters [flink]
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #29463:
URL: https://github.com/apache/flink/pull/29463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org