[jira] [Commented] (YARN-5155) [YARN-3368] Show pending resource requests on application-attempt page

["Sunil G (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323975#comment-15323975 ] 

Sunil G commented on YARN-5155:
-------------------------------

Thanks [~ChenGe] for the patch.

Few comments:
1. Could you pls attach a screen shot?
2. We can see whether we can have auto refresh option is needed here or not.
3. hasMany seems a good choice here. Still when you test the table in an active cluster with 1000's of pending resource requests from an application, how the page is getting rendered? I think it should be good, but we can check once if not done.
4. {{YarnRequest}} seems not correct name. {{resourceRequest}} or {{allocationRequest}} seems more accurate.
5. 
else block might not be required.
{code}
       } else {
         normalizedArrayResponse.data = [];
+        normalizedArrayResponse.included = [];
       }
 
+      normalizedArrayResponse.data = data;
+      normalizedArrayResponse.included = included;
{code}


> [YARN-3368] Show pending resource requests on application-attempt page
> ----------------------------------------------------------------------
>
>                 Key: YARN-5155
>                 URL: https://issues.apache.org/jira/browse/YARN-5155
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Chen Ge
>         Attachments: YARN-5155.wip.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org