You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "James Miller (Created) (JIRA)" <ji...@apache.org> on 2011/11/07 20:28:51 UTC

[jira] [Created] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

CachingHttpClient leaks connections with stale-if-error
-------------------------------------------------------

                 Key: HTTPCLIENT-1143
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: Cache
    Affects Versions: 4.2 Alpha1, 4.1.2
            Reporter: James Miller
            Priority: Critical
             Fix For: Future


If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.

This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

Posted by "Jon Moore (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145787#comment-13145787 ] 

Jon Moore commented on HTTPCLIENT-1143:
---------------------------------------

Hi James, thanks for finding this. I'm actually working on a unit test to reproduce, although I agree you've found a bug and your patch should address it. Just dotting all the i's, so to speak.

                
> CachingHttpClient leaks connections with stale-if-error
> -------------------------------------------------------
>
>                 Key: HTTPCLIENT-1143
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>            Priority: Critical
>              Labels: cache, stale-if-error
>             Fix For: Future
>
>         Attachments: httpclient-1143.patch
>
>
> If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.
> This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Updated] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

Posted by "Jon Moore (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Moore updated HTTPCLIENT-1143:
----------------------------------

    Fix Version/s:     (was: Future)
                   4.2 Alpha2
                   4.1.3
    
> CachingHttpClient leaks connections with stale-if-error
> -------------------------------------------------------
>
>                 Key: HTTPCLIENT-1143
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>            Priority: Critical
>              Labels: cache, stale-if-error
>             Fix For: 4.1.3, 4.2 Alpha2
>
>         Attachments: httpclient-1143.patch
>
>
> If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.
> This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Assigned] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

Posted by "Jon Moore (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Moore reassigned HTTPCLIENT-1143:
-------------------------------------

    Assignee: Jon Moore
    
> CachingHttpClient leaks connections with stale-if-error
> -------------------------------------------------------
>
>                 Key: HTTPCLIENT-1143
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>            Priority: Critical
>              Labels: cache, stale-if-error
>             Fix For: Future
>
>         Attachments: httpclient-1143.patch
>
>
> If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.
> This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Updated] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

Posted by "James Miller (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Miller updated HTTPCLIENT-1143:
-------------------------------------

    Attachment: httpclient-1143.patch

patch for stale-if-error connection leak
                
> CachingHttpClient leaks connections with stale-if-error
> -------------------------------------------------------
>
>                 Key: HTTPCLIENT-1143
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha1
>            Reporter: James Miller
>            Priority: Critical
>              Labels: cache, stale-if-error
>             Fix For: Future
>
>         Attachments: httpclient-1143.patch
>
>
> If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.
> This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

Posted by "Jon Moore (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145808#comment-13145808 ] 

Jon Moore commented on HTTPCLIENT-1143:
---------------------------------------

Patch checked in to trunk with slight modifications, including unit test to reproduce. Thanks, James! I'll work on getting this ported to the release branches next.

                
> CachingHttpClient leaks connections with stale-if-error
> -------------------------------------------------------
>
>                 Key: HTTPCLIENT-1143
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>            Priority: Critical
>              Labels: cache, stale-if-error
>             Fix For: 4.1.3, 4.2 Alpha2
>
>         Attachments: httpclient-1143.patch
>
>
> If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.
> This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Resolved] (HTTPCLIENT-1143) CachingHttpClient leaks connections with stale-if-error

Posted by "Jon Moore (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Moore resolved HTTPCLIENT-1143.
-----------------------------------

    Resolution: Fixed

Patch applied and backported to 4.1.x release branch.

                
> CachingHttpClient leaks connections with stale-if-error
> -------------------------------------------------------
>
>                 Key: HTTPCLIENT-1143
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1143
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>            Priority: Critical
>              Labels: cache, stale-if-error
>             Fix For: 4.1.3, 4.2 Alpha2
>
>         Attachments: httpclient-1143.patch
>
>
> If you are using the "stale-if-error" Cache-control header and CachingHttpClient decides to use a stale cached response it does not clean up the existing backend response.
> This bug causes connections to leak from the connection pool each time the stale-if-error flow is executed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org