You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/07/03 15:31:37 UTC

svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

Author: markt
Date: Tue Jul  3 15:31:37 2018
New Revision: 1834989

URL: http://svn.apache.org/viewvc?rev=1834989&view=rev
Log:
Fix line-endings

Modified:
    tomcat/trunk/bin/makebase.bat   (props changed)
    tomcat/trunk/bin/makebase.sh   (props changed)

Propchange: tomcat/trunk/bin/makebase.bat
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: tomcat/trunk/bin/makebase.sh
------------------------------------------------------------------------------
    svn:eol-style = native



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

Posted by Mark Thomas <ma...@apache.org>.
On 03/07/18 20:33, Violeta Georgieva wrote:
> На вт, 3.07.2018 г. в 21:02 ч. Michael Osipov <mi...@apache.org> написа:
>>
>> Am 2018-07-03 um 17:31 schrieb markt@apache.org:
>>> Author: markt
>>> Date: Tue Jul  3 15:31:37 2018
>>> New Revision: 1834989
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1834989&view=rev
>>> Log:
>>> Fix line-endings
>>>
>>> Modified:
>>>      tomcat/trunk/bin/makebase.bat   (props changed)
>>>      tomcat/trunk/bin/makebase.sh   (props changed)
>>>
>>> Propchange: tomcat/trunk/bin/makebase.bat
>>>
> ------------------------------------------------------------------------------
>>>      svn:eol-style = native
>>
>> That should be CRLF.
>>
>>
>>> Propchange: tomcat/trunk/bin/makebase.sh
>>>
> ------------------------------------------------------------------------------
>>>      svn:eol-style = native
>>
>> Here LF only.
> 
> This is fixed later with
> https://github.com/apache/tomcat/blob/trunk/build.xml#L1800

Exactly.

The choice of native is a deliberate one so cross-platform editing is
simple.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

Posted by Violeta Georgieva <vi...@apache.org>.
На вт, 3.07.2018 г. в 21:02 ч. Michael Osipov <mi...@apache.org> написа:
>
> Am 2018-07-03 um 17:31 schrieb markt@apache.org:
> > Author: markt
> > Date: Tue Jul  3 15:31:37 2018
> > New Revision: 1834989
> >
> > URL: http://svn.apache.org/viewvc?rev=1834989&view=rev
> > Log:
> > Fix line-endings
> >
> > Modified:
> >      tomcat/trunk/bin/makebase.bat   (props changed)
> >      tomcat/trunk/bin/makebase.sh   (props changed)
> >
> > Propchange: tomcat/trunk/bin/makebase.bat
> >
------------------------------------------------------------------------------
> >      svn:eol-style = native
>
> That should be CRLF.
>
>
> > Propchange: tomcat/trunk/bin/makebase.sh
> >
------------------------------------------------------------------------------
> >      svn:eol-style = native
>
> Here LF only.

This is fixed later with
https://github.com/apache/tomcat/blob/trunk/build.xml#L1800

Regards,
Violeta

Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

Posted by Michael Osipov <mi...@apache.org>.
Am 2018-07-03 um 17:31 schrieb markt@apache.org:
> Author: markt
> Date: Tue Jul  3 15:31:37 2018
> New Revision: 1834989
> 
> URL: http://svn.apache.org/viewvc?rev=1834989&view=rev
> Log:
> Fix line-endings
> 
> Modified:
>      tomcat/trunk/bin/makebase.bat   (props changed)
>      tomcat/trunk/bin/makebase.sh   (props changed)
> 
> Propchange: tomcat/trunk/bin/makebase.bat
> ------------------------------------------------------------------------------
>      svn:eol-style = native

That should be CRLF.


> Propchange: tomcat/trunk/bin/makebase.sh
> ------------------------------------------------------------------------------
>      svn:eol-style = native

Here LF only.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org