You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by BenHarnett <gi...@git.apache.org> on 2015/10/28 00:54:23 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Fixed issues causing spi...
GitHub user BenHarnett opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121
Fixed issues causing spinner to not show on web load.
As the spinner and the background were white the spinner was not
showing. Also the frame was being set without taking into consideration
of the site of the main view.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BenHarnett/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 791028444faed1f1c1b26422f1d3a96d1367e790
Author: Ben Harnett <be...@appswiz.com>
Date: 2015-10-27T23:53:59Z
Fixed issues causing spinner to not show on web load.
As the spinner and the background were white the spinner was not
showing. Also the frame was being set without taking into consideration
of the site of the main view.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser issue #121: Fixed issues causing spinner to not ...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121
Closed the PR, it was already covered by #89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed issues causing spi...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121#issuecomment-158437372
Hey Ben, thank you for your patch - it looks good. I've just merged similar fix that was here before (#89) so please take a look whether spinner works for you in master and consider closing this pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request #121: Fixed issues causing spinner ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org