You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/26 12:27:29 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support

szaszm commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676556838



##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
 #else
 			is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
 #endif

Review comment:
       I'd rather not change it now, in the context of this PR. Maybe on the next upgrade?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org