You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Mirai1129 (via GitHub)" <gi...@apache.org> on 2025/05/11 16:47:19 UTC
[PR] KAFKA-19263: update `delete.topic.enable` docs [kafka]
Mirai1129 opened a new pull request, #19675:
URL: https://github.com/apache/kafka/pull/19675
If delete.topic.enable is false on the brokers, deleteTopics will mark the topics for deletion, but not actually delete them. The futures will return successfully in this case.
It is not true as the server return exception now.
```java
if (!config.deleteTopicEnable) {
if (apiVersion < 3) {
throw new InvalidRequestException("Topic deletion is disabled.")
} else {
throw new TopicDeletionDisabledException()
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19263: update `delete.topic.enable` docs [kafka]
Posted by "Mirai1129 (via GitHub)" <gi...@apache.org>.
Mirai1129 commented on PR #19675:
URL: https://github.com/apache/kafka/pull/19675#issuecomment-2871149846
@FrankYang0529 Thanks for the feedback! I’ve updated the documentation, run the server, and attached a screenshot of the result

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19263: update `delete.topic.enable` docs [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19675:
URL: https://github.com/apache/kafka/pull/19675#discussion_r2084486724
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -250,9 +250,9 @@ default DeleteTopicsResult deleteTopics(TopicCollection topics) {
* During this time, {@link #listTopics()} and {@link #describeTopics(Collection)}
* may continue to return information about the deleted topics.
* <p>
- * If delete.topic.enable is false on the brokers, deleteTopics will mark
- * the topics for deletion, but not actually delete them. The futures will
- * return successfully in this case.
+ * If delete.topic.enable is false on the brokers, deleteTopics requests
Review Comment:
```
If delete.topic.enable is set to false on the brokers, an exception will be returned to the client indicating that topic deletion is disabled.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org