[jira] [Comment Edited] (HDFS-6950) Add Additional unit tests for HDFS-6581

["Arpit Agarwal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119338#comment-14119338 ] 

Arpit Agarwal edited comment on HDFS-6950 at 9/3/14 4:52 AM:
-------------------------------------------------------------

Thanks for adding these test cases [~xyao]!

Few comments:
# testFallbackToDiskPartial is failing. The test looks fine so I think it has uncovered a bug. I'll investigate.
# testScopeWriteSameNodeRamDiskOnly - the test case looks incomplete. I don't think there is an easy way to do multi-node testing with our unit tests. Let's move this to another Jira, we can investigate if there is a way to add the test.
# testRamDiskEvictionBeforePersist - The comment _Ensure that both paths exist even after eviction and are readable_ looks unrelated to the test. We can delete it.
# testRamDiskEvictionWithOpenHandle - Let's move this to a separate Jira too. The test will not work as expected.
# testDeleteWithOpenHandle - Same as previous one.
# testDfsUsageCreateDelete - The DFSUsage is expected to change. Perhaps there is a bug because I don't think the test should pass. I'll investigate.
# verifyDeletedBlocks - You can reduce the sleep interval in the loop to 1000ms. Also this function can verify that there is no block file copy in the finalized directory of the transient volume.


was (Author: arpitagarwal):
Thanks for adding these test cases [~xyao]!

Few comments:
# testFallbackToDiskPartial is failing. The test looks fine so I think it has uncovered a bug. I'll investigate.
# testScopeWriteSameNodeRamDiskOnly - the test case looks incomplete. I don't think there is an easy way to do multi-node testing with our unit tests. Let's move this to another Jira, we can investigate if there is a way to add the test.
# testRamDiskEvictionBeforePersist - The comment _Ensure that both paths exist even after eviction and are readable_ looks unrelated to the test. We can delete it.
# testRamDiskEvictionWithOpenHandle - Let's move this to a separate Jira too. The test will not work as expected.
# testDeleteWithOpenHandle - Same as previous one.
# testDfsUsageCreateDelete - I think the test is not doing what you expect. The DFSUsage is 
# verifyDeletedBlocks - You can reduce the sleep interval in the loop to 1000ms. Also this function can verify that there is no block file copy in the finalized directory of the transient volume.

> Add Additional unit tests for HDFS-6581
> ---------------------------------------
>
>                 Key: HDFS-6950
>                 URL: https://issues.apache.org/jira/browse/HDFS-6950
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-6950.0.patch, HDFS-6950.1.patch
>
>
> Create additional unit tests for HDFS-6581 in addition to existing ones in HDFS-6927.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)