You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "stefanvodita (via GitHub)" <gi...@apache.org> on 2024/10/14 16:14:54 UTC

[PR] Add changelog verifier [lucene]

stefanvodita opened a new pull request, #13909:
URL: https://github.com/apache/lucene/pull/13909

   ### Description
   
   This runs along the checks we already have for PR creation/update and warns us if there is no CHANGES.txt entry.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Add changelog verifier [lucene]

Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on PR #13909:
URL: https://github.com/apache/lucene/pull/13909#issuecomment-2413498513

   Is it possible to disable this check based on files that are touched (e.g. test-only fixes don't require a changelog entry) and based on the presence of a label (e.g. mechanical refactorings that have no user-facing impact don't need a changelog entry)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Add changelog verifier [lucene]

Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #13909:
URL: https://github.com/apache/lucene/pull/13909#issuecomment-2415309799

   Right now this would show up like a separate automated check on PRs, which would fail if the changelog is untouched and we don't have the `Skip-Changelog` label. We can override it in cases where we think a changelog entry is not required. To reduce noise from build failure emails, we can run it only for new PRs, once.
   
   We could also make it smarter about the files that are changed in the PR. Useful example: https://fredrikmeyer.net/2021/05/12/github-actions-changelog.html
   
   My preference would have been to make it a comment instead of a failing check, but I haven't found an action that checks file diffs and comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Add changelog verifier [lucene]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13909:
URL: https://github.com/apache/lucene/pull/13909#issuecomment-2445559414

   This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Add changelog verifier [lucene]

Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita commented on PR #13909:
URL: https://github.com/apache/lucene/pull/13909#issuecomment-2692955030

   This was done better in #14279. Plus, I've accidentally overwritten the branch here. Closing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

Re: [PR] Add changelog verifier [lucene]

Posted by "stefanvodita (via GitHub)" <gi...@apache.org>.
stefanvodita closed pull request #13909: Add changelog verifier
URL: https://github.com/apache/lucene/pull/13909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org