Re: [PR] CLI: Add Hive federation option [polaris]

["flyrain (via GitHub)" <gi...@apache.org>]

flyrain commented on code in PR #2798:
URL: https://github.com/apache/polaris/pull/2798#discussion_r2424981823


##########
client/python/cli/command/catalogs.py:
##########
@@ -268,6 +273,14 @@ def _build_connection_config_info(self):
                 service_identity=service_identity,
                 remote_catalog_name=self.iceberg_remote_catalog_name
             )
+        elif self.catalog_connection_type == CatalogConnectionType.HIVE.value:
+            config = HiveConnectionConfigInfo(
+                connection_type=self.catalog_connection_type.upper(),
+                uri=self.catalog_uri,
+                authentication_parameters=auth_params,
+                service_identity=service_identity,
+                warehouse=self.hadoop_warehouse

Review Comment:
   We might just use the name `warehouse`, so that it can be applied to both Hadoop and Hive federation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org