You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/23 15:46:20 UTC
[GitHub] [iceberg] samredai opened a new pull request #4208: Restructure docs files for new contributing guideline
samredai opened a new pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208
This restructures the docs files for the new split contribution model. The updated instructions can be found in the `apache/iceberg-docs` repo, but to summarize: PR's for common pages will go against `apache/iceberg-docs`, and PR's for versioned pages will go against `apache/iceberg`.
Therefore this PR removes the common pages (except for those under `format` such as `spec.md` which will be maintained here). This also flattens the `docs` directory so that it matches what the release manager will need to copy over (just copy the `docs` folder here to `docs` folder in the apache/iceberg-docs repo).
The rest spec has been moved to a root level `open-api` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1057456261
It's out of date again...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1061293862
Looks like we need to turn off CI for `docs/` paths. @kbendick, can you open a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1055992023
@samredai, can you rebase? Looks like there are conflicts now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1061305835
This should cover it. The `docs` folder was already present, but `open-api` and `format` were not: https://github.com/apache/iceberg/pull/4286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1055998603
Thanks for the ping @rdblue. Rebased. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1048969973
@jackye1995 FYI. This restructures docs so that only versioned docs and spec docs are maintained here. The other docs are in the iceberg-docs repo. We think this is easier because we found that a lot of PRs in this repo had to be manually copied over and contributors found it confusing that the source for the common docs were kept in two places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1058663247
@rdblue thanks again, rebased :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1048977867
Looks good to me, but it would be good to hear from @jackye1995 before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4208: Restructure docs files for new contributing guideline
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #4208:
URL: https://github.com/apache/iceberg/pull/4208#issuecomment-1061295082
> Looks like we need to turn off CI for `docs/` paths. @kbendick, can you open a PR?
Yeah will do so now. There are a few other CI related PRs in the pipeline I can help rebase etc if need be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org