You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org> on 2011/11/03 09:53:32 UTC
[jira] [Commented] (BOOKKEEPER-81) disk space of garbage collected
entry logger files isn't reclaimed util process quit
[ https://issues.apache.org/jira/browse/BOOKKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142962#comment-13142962 ]
Flavio Junqueira commented on BOOKKEEPER-81:
--------------------------------------------
This is mostly good, Sijie. Just a couple of quick comments:
# Since we have been working hard to clean up the API, I was wondering if fileChannel() really needs to be public;
# I don't think we have guidelines for writing log messages, but I think it would be nice to make in general message more concise and to try to pick some key words that help us to spot problems more easily. For example, I would rather say "Exception while closing..." rather than "Trying to close...". This is really a small issue, though.
> disk space of garbage collected entry logger files isn't reclaimed util process quit
> -------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-81
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-81
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.0.0
>
> Attachments: bookkeeper-81.patch
>
>
> disk space of garbage collected entry logger files isn't reclaimed until process quit.
> it is caused by entry logger doesn't close the file channel of garbage collected files. so the process kept an reference to this file, filesystem only reclaim its space when the process quit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira