You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/09/30 13:23:01 UTC
Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-13274
https://issues.apache.org/jira/browse/AMBARI-13274
Repository: ambari
Description
-------
Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
Diffs
-----
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
Diff: https://reviews.apache.org/r/38890/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101180
-----------------------------------------------------------
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml (line 39)
<https://reviews.apache.org/r/38890/#comment158529>
Lets change this description to update stack repos as it can update any stack and not just HDP/HDP-UTILS
- Sumit Mohanty
On Sept. 30, 2015, 11:23 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 11:23 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101120
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 30, 2015, 11:23 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 11:23 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101914
-----------------------------------------------------------
ambari-server/src/main/resources/custom_actions/scripts/update_repo.py (line 62)
<https://reviews.apache.org/r/38890/#comment159414>
Let log here full stacktrace, since it's a big piece of code in try catch we might need that.
We might use Logger.logger.exception("ERROR: There was an unexpected error while updating repositories") instead of this print
- Andrew Onischuk
On Oct. 8, 2015, 2:30 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 2:30 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Oct. 8, 2015, 7 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java, line 213
> > <https://reviews.apache.org/r/38890/diff/3/?file=1093189#file1093189line213>
> >
> > Why do we need to remove this check. This is applied when the action definition has TargetHostType as Specific. If its not then this check will not be called.
>
> Vitalyi Brodetskyi wrote:
> Sumit, not sure that it was correct "if" construction. Please take a look at it:
> {code}
> if (TargetHostType.SPECIFIC.equals(actionDef.getTargetType()) || (targetService.isEmpty() && targetComponent.isEmpty()))
> {code}
> this "if" construction checks, if (TargetHostType == SPECIFIC) *OR* (targetService and targetComponent are empty). So, all requests even with targetHostType other than SPECIFIC, will enter to this check, if targetService and targetComponent were not set(most of our custom actions).
>
> Should i leave this check for targetHostType == SPECIFIC, like if (TargetHostType.SPECIFIC.equals(actionDef.getTargetType()) then ... ?
Yes, the if check needs to be modified. It should not report error for targetTypes ALL, ANY, and MAJORITY if host list is empty.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101949
-----------------------------------------------------------
On Oct. 8, 2015, 3:13 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 3:13 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Oct. 8, 2015, 7 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java, line 213
> > <https://reviews.apache.org/r/38890/diff/3/?file=1093189#file1093189line213>
> >
> > Why do we need to remove this check. This is applied when the action definition has TargetHostType as Specific. If its not then this check will not be called.
Sumit, not sure that it was correct "if" construction. Please take a look at it:
{code}
if (TargetHostType.SPECIFIC.equals(actionDef.getTargetType()) || (targetService.isEmpty() && targetComponent.isEmpty()))
{code}
this "if" construction checks, if (TargetHostType == SPECIFIC) *OR* (targetService and targetComponent are empty). So, all requests even with targetHostType other than SPECIFIC, will enter to this check, if targetService and targetComponent were not set(most of our custom actions).
Should i leave this check for targetHostType == SPECIFIC, like if (TargetHostType.SPECIFIC.equals(actionDef.getTargetType()) then ... ?
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101949
-----------------------------------------------------------
On Oct. 8, 2015, 3:13 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 3:13 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101949
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java (line 205)
<https://reviews.apache.org/r/38890/#comment159458>
Why do we need to remove this check. This is applied when the action definition has TargetHostType as Specific. If its not then this check will not be called.
- Sumit Mohanty
On Oct. 8, 2015, 3:13 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 3:13 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101921
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Oct. 8, 2015, 3:13 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 3:13 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/
-----------------------------------------------------------
(Updated Жов. 8, 2015, 3:13 після полудня)
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-13274
https://issues.apache.org/jira/browse/AMBARI-13274
Repository: ambari
Description
-------
Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
Diff: https://reviews.apache.org/r/38890/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101915
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 8, 2015, 2:30 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 2:30 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/#review101917
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Окт. 8, 2015, 2:30 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38890/
> -----------------------------------------------------------
>
> (Updated Окт. 8, 2015, 2:30 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-13274
> https://issues.apache.org/jira/browse/AMBARI-13274
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
> ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
> ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
> ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38890/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 38890: Define a new API to refresh HDP.repo files
using the provided repo baseurl
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38890/
-----------------------------------------------------------
(Updated Жов. 8, 2015, 2:30 після полудня)
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
Bugs: AMBARI-13274
https://issues.apache.org/jira/browse/AMBARI-13274
Repository: ambari
Description
-------
Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> click on the correct version) you have the correct repos. The HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after restart of ambari-server and ambari-agents.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java 1c110fc
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 777ced7
ambari-server/src/main/resources/custom_actions/scripts/update_repo.py PRE-CREATION
ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION
Diff: https://reviews.apache.org/r/38890/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi