You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2016/11/03 04:11:14 UTC

[GitHub] zeppelin pull request #1585: ZEPPELIN-1606. Add interpreter option to interp...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1585

    ZEPPELIN-1606. Add interpreter option to interpreter-setting.json

    ### What is this PR for?
    For livy, the default mode should be scoped per use. This PR is trying to add interpreter option to `interpreter-setting.json` to allow user to set the default mode. 
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    This PR is just a short term solution. There're several followup work needs to be done.
    * Option should be interpretergroup level setting rather than interpreter level setting. 
    * Format of `interperter-setting.json` is not consistent with `Interpereter.json`, there's some code duplication, like `RegisteredInterpereter`,  `InterpreterInfo` and etc. 
    * And this PR doesn't address the issue of mode restriction, user can still change to an invalid mode manually.
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1606
    
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1606

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1585
    
----
commit 26e6cc240eb2ba34f6d7680dca4301325dcce80e
Author: Jeff Zhang <zj...@apache.org>
Date:   2016-11-03T04:05:01Z

    ZEPPELIN-1606. Add interpreter option to interpreter-setting.json

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1585: ZEPPELIN-1606. Add interpreter option to interpreter-s...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/1585
  
    \cc @Leemoonsoo @jongyoul  Please help review, this is a short term solution for livy, I would plan to do the followup work in the Todos.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1585: ZEPPELIN-1606. Add interpreter option to interp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1585


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1585: ZEPPELIN-1606. Add interpreter option to interpreter-s...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/1585
  
    LGTM. We will simplify registration mechanism by deprecating a old way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1585: ZEPPELIN-1606. Add interpreter option to interpreter-s...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1585
  
    LGTM, I like this idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1585: ZEPPELIN-1606. Add interpreter option to interpreter-s...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1585
  
    Thanks @zjffdu for the contribution. LGTM and merge if there're no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---