You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "aihuaxu (via GitHub)" <gi...@apache.org> on 2025/05/04 05:01:58 UTC
[PR] spec: Add missing 'spec_id' for data_file [iceberg]
aihuaxu opened a new pull request, #12970:
URL: https://github.com/apache/iceberg/pull/12970
From https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/DataFile.java#L100, we are missing `spec_id` description in the spec for data_file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] spec: Add missing 'spec_id' for data_file [iceberg]
Posted by "aihuaxu (via GitHub)" <gi...@apache.org>.
aihuaxu commented on PR #12970:
URL: https://github.com/apache/iceberg/pull/12970#issuecomment-2851768896
@szehon-ho I saw you added this and you might have more context. Can you help take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] spec: Add missing 'spec_id' for data_file [iceberg]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #12970:
URL: https://github.com/apache/iceberg/pull/12970#issuecomment-2852090568
@aihuaxu its been a long time , but can we check if its actually serialized? i need to double check it but I thought we just derive this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] spec: Add missing 'spec_id' for data_file [iceberg]
Posted by "aihuaxu (via GitHub)" <gi...@apache.org>.
aihuaxu commented on PR #12970:
URL: https://github.com/apache/iceberg/pull/12970#issuecomment-2852239700
> @aihuaxu its been a long time , but can we check if its actually serialized? i need to double check it but I thought we just derive this.
It's derived and it's serialized to avro file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] spec: Add missing 'spec_id' for data_file [iceberg]
Posted by "aihuaxu (via GitHub)" <gi...@apache.org>.
aihuaxu commented on PR #12970:
URL: https://github.com/apache/iceberg/pull/12970#issuecomment-2852381319
> @aihuaxu its been a long time , but can we check if its actually serialized? i need to double check it but I thought we just derive this.
I think you are right. I'm checking the file but don't see that is serialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] spec: Add missing 'spec_id' for data_file [iceberg]
Posted by "aihuaxu (via GitHub)" <gi...@apache.org>.
aihuaxu closed pull request #12970: spec: Add missing 'spec_id' for data_file
URL: https://github.com/apache/iceberg/pull/12970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org