[GitHub] [camel-k] squakez commented on a diff in pull request #3312: Detect wire tap EIP endpoints

[GitBox <gi...@apache.org>]

squakez commented on code in PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#discussion_r885249758


##########
pkg/util/source/inspector_yaml.go:
##########
@@ -161,7 +161,7 @@ func (i YAMLInspector) parseStep(key string, content interface{}, meta *Metadata
 		switch key {
 		case "from":
 			meta.FromURIs = append(meta.FromURIs, maybeURI)
-		case "to", "to-d", "toD":
+		case "to", "to-d", "toD", "wire-tap", "wireTap":
 			meta.ToURIs = append(meta.ToURIs, maybeURI)

Review Comment:
   `meta.ToURIs` is reserved for the `to` DSL parameter



##########
pkg/util/source/inspector_yaml_test.go:
##########
@@ -125,6 +135,14 @@ func TestYAMLDependencies(t *testing.T) {
 				`mvn:org.apache.camel.k:camel-k-knative-consumer`,
 			},
 		},
+		{
+			name:   "wireTap",
+			source: YAMLWiretapEIP,
+			dependencies: []string{
+				`mvn:org.apache.camel.k:camel-k-knative-producer`,
+				`mvn:org.apache.camel.k:camel-k-knative-consumer`,

Review Comment:
   we're missing to check if the wiretap dependency component is present at this stage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org