You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by do...@apache.org on 2021/11/19 21:25:57 UTC

[arrow] 01/03: ARROW-14773: [JS] Fix sourcemap paths

This is an automated email from the ASF dual-hosted git repository.

domoritz pushed a commit to branch release-6.0.2-js
in repository https://gitbox.apache.org/repos/asf/arrow.git

commit dcc7d6b7243954a3e7c4e04a455e773b1b09c33c
Author: Dominik Moritz <do...@gmail.com>
AuthorDate: Fri Nov 19 16:05:16 2021 -0500

    ARROW-14773: [JS] Fix sourcemap paths
    
    This fixes an issue where the source maps point to files in the root directory, not `src`, which is where the sources actually are.
    
    Closes #11741 from domoritz/dom/sourcemaps
    
    Authored-by: Dominik Moritz <do...@gmail.com>
    Signed-off-by: Dominik Moritz <do...@gmail.com>
---
 js/gulp/typescript-task.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/js/gulp/typescript-task.js b/js/gulp/typescript-task.js
index ed03b84..cc1d277 100644
--- a/js/gulp/typescript-task.js
+++ b/js/gulp/typescript-task.js
@@ -66,12 +66,12 @@ function compileTypescript(out, tsconfigPath, tsconfigOverrides) {
     const writeSources = observableFromStreams(tsProject.src(), gulp.dest(path.join(out, 'src')));
     const writeDTypes = observableFromStreams(dts, sourcemaps.write('./', { includeContent: false, sourceRoot: 'src' }), gulp.dest(out));
     const mapFile = tsProject.options.module === 5 ? esmMapFile : cjsMapFile;
-    const writeJS = observableFromStreams(js, sourcemaps.write('./', { mapFile, includeContent: false }), gulp.dest(out));
+    const writeJS = observableFromStreams(js, sourcemaps.write('./', { mapFile, includeContent: false, sourceRoot: 'src' }), gulp.dest(out));
     return ObservableForkJoin([writeSources, writeDTypes, writeJS]);
 }
 
-function cjsMapFile(mapFilePath) { return mapFilePath; }
-function esmMapFile(mapFilePath) { return mapFilePath.replace('.js.map', '.mjs.map'); }
+const cjsMapFile = (mapFilePath) => mapFilePath;
+const esmMapFile = (mapFilePath) => mapFilePath.replace('.js.map', '.mjs.map');
 
 module.exports = typescriptTask;
 module.exports.typescriptTask = typescriptTask;