You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/05 11:20:24 UTC
[GitHub] [shardingsphere] totalo opened a new pull request, #22672: Remove the sharding examples and use the automatically generated examples
totalo opened a new pull request, #22672:
URL: https://github.com/apache/shardingsphere/pull/22672
For #12366.
Changes proposed in this pull request:
- Remove the sharding examples and use the automatically generated examples
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22672: Remove the sharding examples and use the automatically generated examples
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22672:
URL: https://github.com/apache/shardingsphere/pull/22672#issuecomment-1337197320
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22672?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22672](https://codecov.io/gh/apache/shardingsphere/pull/22672?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6b301d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a5376746baf03821852317549907b6198d71e33a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a537674) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22672 +/- ##
=========================================
Coverage 49.37% 49.37%
Complexity 2440 2440
=========================================
Files 4108 4108
Lines 57437 57437
Branches 9841 9841
=========================================
Hits 28358 28358
Misses 26633 26633
Partials 2446 2446
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] totalo commented on pull request #22672: Remove the sharding examples and use the automatically generated examples
Posted by GitBox <gi...@apache.org>.
totalo commented on PR #22672:
URL: https://github.com/apache/shardingsphere/pull/22672#issuecomment-1338679824
> Please resolve conflicts
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #22672: Remove the sharding examples and use the automatically generated examples
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #22672:
URL: https://github.com/apache/shardingsphere/pull/22672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #22672: Remove the sharding examples and use the automatically generated examples
Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #22672:
URL: https://github.com/apache/shardingsphere/pull/22672#issuecomment-1337646089
Please resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org