You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/10/14 10:54:43 UTC

[PR] build(ci): build a reduced matrix on pull requests [struts]

lukaszlenart opened a new pull request, #2011:
URL: https://github.com/apache/struts/pull/2011

   ## Why
   
   GitHub Actions jobs here spend 30–90 minutes queued on the shared ASF runner pool and 1–7 minutes running. Each push to a pull request queued 8 jobs. This PR halves that.
   
   It complements #2010, which removes the separate `changes` job so that each job queues once instead of twice. The two are kept apart so that each one's effect is visible on its own.
   
   ## What changes
   
   - **Maven matrix.** The matrix is restructured into `java` × `profile` dimensions. The JDK 17 + Jakarta EE 11 combination is excluded, which leaves the same 5 combinations and the same check names as before.
     - On pull requests, two expression-based excludes also drop JDK 21 and plain JDK 25. A PR builds **JDK 17**, which is the required check, and **JDK 25 with `-Pjakartaee11`**. That covers the oldest JDK and the newest stack.
     - Pushes to `main` / `develop` / `release/*` / `support/*` and `workflow_dispatch` still build all 5 combinations.
   - **OWASP.** On pull requests it runs only when a `pom.xml`, `src/etc/project-suppression.xml` or the workflow itself changes. It isn't a required check, so the path filter can't leave a PR blocked. All dependencies are declared in `pom.xml` files.
   
   A PR push now queues 4 jobs instead of 8: JDK 17, JDK 25 + Jakarta EE 11, CodeQL and Sonar.
   
   ## Trade-offs
   
   - A failure that appears only on JDK 21, or only on plain JDK 25, shows up after merge instead of on the PR.
   - A new CVE against a dependency that hasn't changed is reported by the push run on `main`, not on unrelated PRs.
   
   ## Verification
   
   - `actionlint` is clean.
   - This PR's own run should show exactly two "Build and Test" jobs and no OWASP job.
   - The push path (full matrix) shows up on the first `main` build after merge, or earlier with a `workflow_dispatch` on this branch.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] build(ci): build a reduced matrix on pull requests [struts]

Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #2011:
URL: https://github.com/apache/struts/pull/2011


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] build(ci): build a reduced matrix on pull requests [struts]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2011:
URL: https://github.com/apache/struts/pull/2011#issuecomment-6169336032

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2011) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2011&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2011&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2011&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2011&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2011&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2011)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org