You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/12/04 18:04:42 UTC

[GitHub] [geode] kirklund opened pull request #2945: GEODE-6122: Delete old Logging performance tests

The old perf tests are replaced with new JMH benchmarks:
* CacheLoggingBenchmark
* LogWriterAppenderBenchmark


[ Full content available at: https://github.com/apache/geode/pull/2945 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2945: GEODE-6122: Delete old Logging performance tests

Posted by "kirklund (GitHub)" <gi...@apache.org>.
The commit which introduced the new Logging JMH benchmarks was. I just didn't get around to removing the old perf tests until this new PR:
```
commit 4be9e7aa4cd90ca5ac4410d04aadfc3a4efcbba0
Author: Kirk Lund <kl...@apache.org>
Date:   Fri Nov 2 17:03:24 2018 -0700

    GEODE-2644: Make LogWriterAppender optional and support log4j2.xml
    
    LogWriterAppender is now configured in log4j2.xml and it supports
    sessions that correspond with Cache lifecycle. This allows Geode to
    pause and resume LogWriterAppender and GeodeConsoleAppender without
    resorting to dynamically adding and removing appenders.
    
    When the Cache exists, log events stop going to the Console and instead
    go to the Geode log file. Whenever the Cache does not exist, log events
    go only to the Console.
    
    These changes remove as much of the Log4j2 Core manipulation as
    possible.
    
    Also fixed:
    * GEODE-5789: Geode now updates log level of all Geode loggers.
    
    List of changes:
    * Change LogWriterAppender to be pausable and session-oriented
    * Add GeodeConsoleAppender which is pausable
    * Log4j2 Core dependency is now optional
    * Internal Logging interfaces allow Logging service to be pluggable
    * Log4j2 xml integration testing now uses JUnit Rule from Log4j2
    * Reduce coupling between Logging and the rest of Geode
    * Greatly increase test coverage for Logging
```

[ Full content available at: https://github.com/apache/geode/pull/2945 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #2945: GEODE-6122: Delete old Logging performance tests

Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/2945 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2945: GEODE-6122: Delete old Logging performance tests

Posted by "kirklund (GitHub)" <gi...@apache.org>.
Note this would've been an additional commit on my main GEODE-6122 PR #2944 but I moved it to its own PR.

[ Full content available at: https://github.com/apache/geode/pull/2945 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org