[GitHub] [accumulo] ctubbsii commented on issue #1586: Fix Accumulo hanging when TLS enabled on ZooKeeper

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1586: Fix Accumulo hanging when TLS enabled on ZooKeeper
URL: https://github.com/apache/accumulo/pull/1586#issuecomment-613639163
 
 
   > Another way to make this change cleaner would be to call `SingletonManager.setMode(CLOSED)` in `ServerContext.close()`. However doing this may destabilize existing code using ServerContext. To avoid the destabilization, could create an AdminUtilContext that extends ServerContext AND calls `SingletonManager.setMode(CLOSED)` in its close method. Then admin util like the ones changed in this PR could do something like the following.
   
   We've talked about creating a Context for utilities before. I think it probably makes sense to do that for this reason as well.
   
   Another way to simplify this is to let the context explicitly manage the ZooKeeper object, rather than use the SingletonManager stuff at all. In my view, the SingletonManager was a short-term hack to manage static object lifecycles, when the long-term fix is to avoid static objects. The context object is the primary lifecycle object, so we really should only be getting our ZooKeeper object from that. The context itself should close the ZooKeeper object when it is closed.
   
   > Just sharing my thoughts, not suggesting we do any of this at this point.
   
   Yeah, all these ideas can be left for future changes/improvements. The approach taken by this PR is fine with me for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services