You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2026/01/26 09:43:01 UTC
(tomcat) 01/02: Avoid changing channel state on reset(null,null)
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 4e8eead5d470188f83c504873e766239dafdc324
Author: remm <re...@apache.org>
AuthorDate: Mon Jan 26 10:38:27 2026 +0100
Avoid changing channel state on reset(null,null)
BZ69938
---
java/org/apache/tomcat/util/net/SecureNioChannel.java | 12 +++++++-----
webapps/docs/changelog.xml | 4 ++++
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/SecureNioChannel.java b/java/org/apache/tomcat/util/net/SecureNioChannel.java
index af80209cbf..95b9754745 100644
--- a/java/org/apache/tomcat/util/net/SecureNioChannel.java
+++ b/java/org/apache/tomcat/util/net/SecureNioChannel.java
@@ -94,11 +94,13 @@ public class SecureNioChannel extends NioChannel {
public void reset(SocketChannel channel, NioSocketWrapper socketWrapper) throws IOException {
super.reset(channel, socketWrapper);
sslEngine = null;
- sniComplete = false;
- handshakeComplete = false;
- closed = false;
- closing = false;
- netInBuffer.clear();
+ if (channel != null) {
+ sniComplete = false;
+ handshakeComplete = false;
+ closed = false;
+ closing = false;
+ netInBuffer.clear();
+ }
}
@Override
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 446c345738..8fec7ded46 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -122,6 +122,10 @@
shutdown that triggered a significant memory leak. Patch provided by
Wes. (markt)
</fix>
+ <fix>
+ <bug>69938</bug>: Avoid changing the closed state of TLS channel when
+ resetting it after close. (remm)
+ </fix>
</changelog>
</subsection>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org