[GitHub] [flume] AndreLouisCaron commented on a change in pull request #321: ElasticSearch cluster name is optional for REST client

[GitBox <gi...@apache.org>]

AndreLouisCaron commented on a change in pull request #321: ElasticSearch cluster name is optional for REST client
URL: https://github.com/apache/flume/pull/321#discussion_r399008151
 
 

 ##########
 File path: flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java
 ##########
 @@ -20,14 +20,16 @@
 
 import org.apache.flume.sink.elasticsearch.ElasticSearchEventSerializer;
 import org.apache.flume.sink.elasticsearch.ElasticSearchIndexRequestBuilderFactory;
+import static org.apache.flume.sink.elasticsearch.ElasticSearchSinkConstants.TRANSPORT_CLIENT;
+import static org.apache.flume.sink.elasticsearch.ElasticSearchSinkConstants.REST_CLIENT;
 
 /**
  * Internal ElasticSearch client factory. Responsible for creating instance
  * of ElasticSearch clients.
  */
 public class ElasticSearchClientFactory {
-  public static final String TransportClient = "transport";
-  public static final String RestClient = "rest";
+  public static final String TransportClient = TRANSPORT_CLIENT;
+  public static final String RestClient = REST_CLIENT;
 
 Review comment:
   Note to reviewers: these seem to be used in quite a few places.  Preserving the original names makes the diff smaller.  Let me know if you prefer that I replace the names instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services