You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Martin Desruisseaux (Jira)" <ji...@apache.org> on 2025/04/12 21:18:00 UTC

[jira] [Updated] (MNG-8686) Common includes/excludes implementation

     [ https://issues.apache.org/jira/browse/MNG-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Desruisseaux updated MNG-8686:
-------------------------------------
    Description: 
Part of the work for reducing the dependency to Plexus was to replace includes/excludes support by the standard {{java.nio.file.PathMatcher}}. But that standard interface matches against a single pattern. We still need code for matches against multiple includes/excludes. The {{maven-clean-plugin}} and {{maven-compiler-plugin}} both have their own code. This causes redundancies, but also slight inconsistencies as they were not implemented in the same way (the {{maven-clean-plugin}} implementation is more elaborated). Moving the implementation to code would reduce redundancies and inconsistencies.

This is implemented in pull request https://github.com/apache/maven/pull/2236


  was:
Part of the work for reducing the dependency to Plexus was to replace includes/excludes support by the standard `java.nio.file.PathMatcher`. But that standard interface matches against a single pattern. We still need code for matches against multiple includes/excludes. The `maven-clean-plugin` and `maven-compiler-plugin` both have their own code. This causes redundancies, but also slight inconsistencies as they were not implemented in the same way (the `maven-clean-plugin` implementation is more elaborated). Moving the implementation to code would reduce redundancies and inconsistencies.

This is implemented in pull request https://github.com/apache/maven/pull/2236



> Common includes/excludes implementation
> ---------------------------------------
>
>                 Key: MNG-8686
>                 URL: https://issues.apache.org/jira/browse/MNG-8686
>             Project: Maven
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Martin Desruisseaux
>            Priority: Major
>
> Part of the work for reducing the dependency to Plexus was to replace includes/excludes support by the standard {{java.nio.file.PathMatcher}}. But that standard interface matches against a single pattern. We still need code for matches against multiple includes/excludes. The {{maven-clean-plugin}} and {{maven-compiler-plugin}} both have their own code. This causes redundancies, but also slight inconsistencies as they were not implemented in the same way (the {{maven-clean-plugin}} implementation is more elaborated). Moving the implementation to code would reduce redundancies and inconsistencies.
> This is implemented in pull request https://github.com/apache/maven/pull/2236



--
This message was sent by Atlassian Jira
(v8.20.10#820010)