[GitHub] [buildstream] cs-shadow commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements

[GitBox <gi...@apache.org>]

cs-shadow commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r1059059565


##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
 click==8.1.3
 grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
 pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
 psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1

Review Comment:
   fwiw setuptools is NOT here because buildstream uses it at build-time. That should be in pyproject.toml as you mention above.
   
   The reason setuptools is here (as a runtime requirement) is because buildtream uses `pkg_resources` around [here](https://github.com/apache/buildstream/blob/416bdd04a03d55e387d2d777cc115a295003daa2/src/buildstream/_pluginfactory/pluginoriginpip.py#L35) and `pkg_resources` module is provided by the `setuptools` package.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org