You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/11/14 11:31:17 UTC
[PR] refactor(core)!: Remove range writer which never been used [opendal]
Xuanwo opened a new pull request, #5323:
URL: https://github.com/apache/opendal/pull/5323
# Which issue does this PR close?
None
# Rationale for this change
Dead Code
# What changes are included in this PR?
This PR will remove RangeWriter which never been used
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core)!: Remove the range writer that has never been used [opendal]
Posted by "codspeed-hq[bot] (via GitHub)" <gi...@apache.org>.
codspeed-hq[bot] commented on PR #5323:
URL: https://github.com/apache/opendal/pull/5323#issuecomment-2476131619
## [CodSpeed Performance Report](https://codspeed.io/apache/opendal/branches/remove-range-writer)
### Merging #5323 will **degrade performances by 18.88%**
<sub>Comparing <code>remove-range-writer</code> (dbf95bb) with <code>main</code> (104727c)</sub>
### Summary
`⚡ 1` improvements
`❌ 8` regressions
`✅ 64` untouched benchmarks
> :warning: _Please fix the performance issues or [acknowledge them on CodSpeed](https://codspeed.io/apache/opendal/branches/remove-range-writer)._
### Benchmarks breakdown
| | Benchmark | `main` | `remove-range-writer` | Change |
| --- | --------- | ----------------------- | ------------------- | ------ |
| ❌ | `256 KiB * 1000k chunk` | 125.3 ns | 154.4 ns | -18.88% |
| ❌ | `256 KiB * 1000k truncate` | 216.7 ns | 245.8 ns | -11.86% |
| ❌ | `256 KiB * 100k chunk` | 125.3 ns | 154.4 ns | -18.88% |
| ❌ | `256 KiB * 100k truncate` | 216.7 ns | 245.8 ns | -11.86% |
| ❌ | `256 KiB * 10k chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `256 KiB * 10k truncate` | 216.7 ns | 245.8 ns | -11.86% |
| ❌ | `256 KiB * 1k chunk` | 125.3 ns | 154.4 ns | -18.88% |
| ❌ | `256 KiB * 1k truncate` | 216.7 ns | 245.8 ns | -11.86% |
| ⚡ | `concurrent 8` | 365.4 µs | 327.3 µs | +11.62% |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core)!: Remove the range writer that has never been used [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5323:
URL: https://github.com/apache/opendal/pull/5323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(core)!: Remove the range writer that has never been used [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #5323:
URL: https://github.com/apache/opendal/pull/5323#issuecomment-2476356536
Thank you @koushiro for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org