You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/06/06 21:22:45 UTC
[jira] Created: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
FSNamesystem.close() throws NullPointerException
------------------------------------------------
Key: HADOOP-3509
URL: https://issues.apache.org/jira/browse/HADOOP-3509
Project: Hadoop Core
Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
{noformat}
2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-3509:
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thank you Nicholas.
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.18.0
>
> Attachments: 3509_20080606.patch, 3509_20080606b.patch, 3509_20080606c.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603228#action_12603228 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3509:
------------------------------------------------
Passed ant test and ant test-patch locally.
{noformat}
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
{noformat}
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3509_20080606.patch, 3509_20080606b.patch, 3509_20080606c.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3509:
-------------------------------------------
Attachment: 3509_20080606.patch
3509_20080606.patch: check null before calling close(). I tested manually. No new tests added.
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 3509_20080606.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603217#action_12603217 ]
Konstantin Shvachko commented on HADOOP-3509:
---------------------------------------------
+1
This is good. I like IOUtils.close().
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3509_20080606.patch, 3509_20080606b.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3509:
-------------------------------------------
Attachment: 3509_20080606c.patch
3509_20080606c.patch: updated javadoc
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3509_20080606.patch, 3509_20080606b.patch, 3509_20080606c.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3509:
-------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
Status: Patch Available (was: Open)
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3509_20080606.patch, 3509_20080606b.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3509) FSNamesystem.close() throws
NullPointerException
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3509:
-------------------------------------------
Attachment: 3509_20080606b.patch
3509_20080606b.patch: added IOUtils.close(...)
> FSNamesystem.close() throws NullPointerException
> ------------------------------------------------
>
> Key: HADOOP-3509
> URL: https://issues.apache.org/jira/browse/HADOOP-3509
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 3509_20080606.patch, 3509_20080606b.patch
>
>
> During NameNode startup, if there is an exception thrown before FSNamesystem.dir is created, we will get a NullPointerException.
> {noformat}
> 2008-06-06 12:07:21,203 ERROR org.apache.hadoop.dfs.NameNode: java.lang.NullPointerException
> at org.apache.hadoop.dfs.FSNamesystem.close(FSNamesystem.java:465)
> at org.apache.hadoop.dfs.FSNamesystem.<init>(FSNamesystem.java:253)
> at org.apache.hadoop.dfs.NameNode.initialize(NameNode.java:148)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:193)
> at org.apache.hadoop.dfs.NameNode.<init>(NameNode.java:179)
> at org.apache.hadoop.dfs.NameNode.createNameNode(NameNode.java:822)
> at org.apache.hadoop.dfs.NameNode.main(NameNode.java:831)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.