[jira] [Commented] (ARROW-2442) [C++] Disambiguate Builder::Append overloads

["Rok Mihevc (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17659469#comment-17659469 ] 

Rok Mihevc commented on ARROW-2442:
-----------------------------------

This issue has been migrated to [issue #18575|https://github.com/apache/arrow/issues/18575] on GitHub. Please see the [migration documentation|https://github.com/apache/arrow/issues/14542] for further details.

> [C++] Disambiguate Builder::Append overloads
> --------------------------------------------
>
>                 Key: ARROW-2442
>                 URL: https://issues.apache.org/jira/browse/ARROW-2442
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.9.0
>            Reporter: Antoine Pitrou
>            Assignee: Antoine Pitrou
>            Priority: Major
>              Labels: beginner, pull-request-available
>             Fix For: 0.10.0
>
>
> See discussion in [https://github.com/apache/arrow/pull/1852#discussion_r179919627]
> There are various {{Append()}} overloads in Builder and subclasses, some of which append one value, some of which append multiple values at once.
> The API might be clearer and less error-prone if multiple-append variants were named differently, for example {{AppendValues()}}. Especially with the pointer-taking variants, it's probably easy to call the wrong overload by mistake.
> The existing methods would have to go through a deprecation cycle.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)