You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/12 01:59:29 UTC
[GitHub] [flink] caozhen1937 opened a new pull request #13122: [FLINK-18824][Table SQL][Formats]Support serialization for canal-json format
caozhen1937 opened a new pull request #13122:
URL: https://github.com/apache/flink/pull/13122
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Support serialization for canal-json format*
## Brief change log
- add SerializationSchema for serialize data to byte[]
- add formatfactory for SerializationSchema
## Verifying this change
- Added java tests for serialize data to byte[] into table sink
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13122:
URL: https://github.com/apache/flink/pull/13122#discussion_r472805841
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonFormatFactory.java
##########
@@ -56,16 +57,16 @@
@SuppressWarnings("unchecked")
@Override
public DecodingFormat<DeserializationSchema<RowData>> createDecodingFormat(
- DynamicTableFactory.Context context,
- ReadableConfig formatOptions) {
+ DynamicTableFactory.Context context,
+ ReadableConfig formatOptions) {
Review comment:
Please keep indent for the method parameters.
Same to the following mehods.
##########
File path: flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/canal/CanalJsonSerDeserSchemaTest.java
##########
@@ -131,27 +131,72 @@ public void testDeserialization() throws Exception {
"-D(102,car battery,12V car battery,5.17)",
"-D(103,12-pack drill bits,12-pack of drill bits with sizes ranging from #40 to #3,0.8)"
);
- assertEquals(expected, collector.list);
+ List<String> actual = collector.list.stream()
+ .map(Object::toString)
+ .collect(Collectors.toList());
+ assertEquals(expected, actual);
+
Review comment:
remove empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
}, {
"hash" : "732127f4acc127b190673a09c6a3426988ee51e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802",
"triggerID" : "732127f4acc127b190673a09c6a3426988ee51e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 732127f4acc127b190673a09c6a3426988ee51e2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434)
* 5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][Table SQL][Formats]Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
}, {
"hash" : "732127f4acc127b190673a09c6a3426988ee51e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802",
"triggerID" : "732127f4acc127b190673a09c6a3426988ee51e2",
"triggerType" : "PUSH"
}, {
"hash" : "1c448cfcac75bd818b6d8e1609f891418d892b7c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c448cfcac75bd818b6d8e1609f891418d892b7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 732127f4acc127b190673a09c6a3426988ee51e2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802)
* 1c448cfcac75bd818b6d8e1609f891418d892b7c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434)
* 5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
}, {
"hash" : "732127f4acc127b190673a09c6a3426988ee51e2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "732127f4acc127b190673a09c6a3426988ee51e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790)
* 732127f4acc127b190673a09c6a3426988ee51e2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] caozhen1937 commented on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
caozhen1937 commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-678872182
ok, I will update the documentation to introduce this new feature @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13122:
URL: https://github.com/apache/flink/pull/13122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
}, {
"hash" : "732127f4acc127b190673a09c6a3426988ee51e2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802",
"triggerID" : "732127f4acc127b190673a09c6a3426988ee51e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790)
* 732127f4acc127b190673a09c6a3426988ee51e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
}, {
"hash" : "732127f4acc127b190673a09c6a3426988ee51e2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802",
"triggerID" : "732127f4acc127b190673a09c6a3426988ee51e2",
"triggerType" : "PUSH"
}, {
"hash" : "1c448cfcac75bd818b6d8e1609f891418d892b7c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6000",
"triggerID" : "1c448cfcac75bd818b6d8e1609f891418d892b7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 732127f4acc127b190673a09c6a3426988ee51e2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802)
* 1c448cfcac75bd818b6d8e1609f891418d892b7c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6000)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
}, {
"hash" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5790",
"triggerID" : "5bbc2d4544ff3d3f894a921a1ecdbdc32e211dcc",
"triggerType" : "PUSH"
}, {
"hash" : "732127f4acc127b190673a09c6a3426988ee51e2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5802",
"triggerID" : "732127f4acc127b190673a09c6a3426988ee51e2",
"triggerType" : "PUSH"
}, {
"hash" : "1c448cfcac75bd818b6d8e1609f891418d892b7c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6000",
"triggerID" : "1c448cfcac75bd818b6d8e1609f891418d892b7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c448cfcac75bd818b6d8e1609f891418d892b7c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6000)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][Table SQL][Formats]Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] caozhen1937 commented on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
caozhen1937 commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-678713416
PTAL @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] caozhen1937 commented on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
caozhen1937 commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672628417
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] caozhen1937 commented on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
caozhen1937 commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-678907956
PTAL @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13122: [FLINK-18824][Table SQL][Formats]Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672456839
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0517cad763355d9f74172ad6d1e7c70a2038e742 (Wed Aug 12 02:01:03 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-684316789
Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13122: [FLINK-18824][format][canal] Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
}, {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434",
"triggerID" : "672628417",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5422) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5434)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13122: [FLINK-18824][Table SQL][Formats]Support serialization for canal-json format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13122:
URL: https://github.com/apache/flink/pull/13122#issuecomment-672466736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0517cad763355d9f74172ad6d1e7c70a2038e742",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0517cad763355d9f74172ad6d1e7c70a2038e742 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org