You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2013/05/15 01:41:23 UTC
svn commit: r1482642 -
/lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Author: hossman
Date: Tue May 14 23:41:23 2013
New Revision: 1482642
URL: http://svn.apache.org/r1482642
Log:
LUCENE-5001: update Constants.LUCENE_MAIN_VERSION for 4.3.1
Modified:
lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Modified: lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java?rev=1482642&r1=1482641&r2=1482642&view=diff
==============================================================================
--- lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java (original)
+++ lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java Tue May 14 23:41:23 2013
@@ -122,7 +122,7 @@ public final class Constants {
/**
* This is the internal Lucene version, recorded into each segment.
*/
- public static final String LUCENE_MAIN_VERSION = ident("4.3");
+ public static final String LUCENE_MAIN_VERSION = ident("4.3.1");
/**
* This is the Lucene version for display purposes.
Re: svn commit: r1482642 - /lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
I have backported LUCENE-4949 to the 4.3 branch.
On Wed, May 15, 2013 at 9:00 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> Hi,
>
> ok, I just wanted to be sure!
>
> > I double checked (also 3.6.1, 3.6.2, and 4.2.1 releases): hossman's
> commit is
> > correct actually.
> >
> > This is the one used for back compat (its tested with the version
> > comparator), but its just marking which version of lucene wrote the
> > segment. The variable name should really be changed, "MAIN" says nothing.
> >
> > This one is the more important one though: another reason why its not
> > triggered by the version sysprop from build.xml: our comparator cannot
> deal
> > with any -SNAPSHOT or any maven suffixes or any of that horseshit. it
> needs
> > real version numbers.
>
> In trunk and branch_4x we already changed the numbering in common-build to
> fix some bugs with Jenkins! We have now:
> <property name="dev.version.base" value="4.4"/>
> We should maybe backport this commit to 4.3, too.
>
> So we can use this to maybe check consistency or pass this version somehow
> to tests.
>
> Our version comparator can handle those versions, so it expands missing
> parts with ".0", so e.g. "4.3.1" is considered greater than "4.3" (which is
> treated as "4.3.0").
>
> > On Wed, May 15, 2013 at 7:57 AM, Robert Muir <rc...@gmail.com> wrote:
> > > On Wed, May 15, 2013 at 4:23 AM, Uwe Schindler <uw...@thetaphi.de>
> > wrote:
> > >> Are we sure that this is the right thing? The LUCENE_MAIN_VERSION is
> > used for index compatibility and should always be only in X.Y format.
> > >>
> > >> Please revert this!
> > >>
> > >
> > > Uwe is correct: please only adjust build.xml here or whatever, but
> > > don't change this!
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> > commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Regards,
Shalin Shekhar Mangar.
RE: svn commit: r1482642 - /lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi,
ok, I just wanted to be sure!
> I double checked (also 3.6.1, 3.6.2, and 4.2.1 releases): hossman's commit is
> correct actually.
>
> This is the one used for back compat (its tested with the version
> comparator), but its just marking which version of lucene wrote the
> segment. The variable name should really be changed, "MAIN" says nothing.
>
> This one is the more important one though: another reason why its not
> triggered by the version sysprop from build.xml: our comparator cannot deal
> with any -SNAPSHOT or any maven suffixes or any of that horseshit. it needs
> real version numbers.
In trunk and branch_4x we already changed the numbering in common-build to fix some bugs with Jenkins! We have now:
<property name="dev.version.base" value="4.4"/>
We should maybe backport this commit to 4.3, too.
So we can use this to maybe check consistency or pass this version somehow to tests.
Our version comparator can handle those versions, so it expands missing parts with ".0", so e.g. "4.3.1" is considered greater than "4.3" (which is treated as "4.3.0").
> On Wed, May 15, 2013 at 7:57 AM, Robert Muir <rc...@gmail.com> wrote:
> > On Wed, May 15, 2013 at 4:23 AM, Uwe Schindler <uw...@thetaphi.de>
> wrote:
> >> Are we sure that this is the right thing? The LUCENE_MAIN_VERSION is
> used for index compatibility and should always be only in X.Y format.
> >>
> >> Please revert this!
> >>
> >
> > Uwe is correct: please only adjust build.xml here or whatever, but
> > don't change this!
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1482642 - /lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Posted by Robert Muir <rc...@gmail.com>.
I double checked (also 3.6.1, 3.6.2, and 4.2.1 releases): hossman's
commit is correct actually.
This is the one used for back compat (its tested with the version
comparator), but its just marking which version of lucene wrote the
segment. The variable name should really be changed, "MAIN" says
nothing.
This one is the more important one though: another reason why its not
triggered by the version sysprop from build.xml: our comparator cannot
deal with any -SNAPSHOT or any maven suffixes or any of that
horseshit. it needs real version numbers.
On Wed, May 15, 2013 at 7:57 AM, Robert Muir <rc...@gmail.com> wrote:
> On Wed, May 15, 2013 at 4:23 AM, Uwe Schindler <uw...@thetaphi.de> wrote:
>> Are we sure that this is the right thing? The LUCENE_MAIN_VERSION is used for index compatibility and should always be only in X.Y format.
>>
>> Please revert this!
>>
>
> Uwe is correct: please only adjust build.xml here or whatever, but
> don't change this!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1482642 - /lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Posted by Robert Muir <rc...@gmail.com>.
On Wed, May 15, 2013 at 4:23 AM, Uwe Schindler <uw...@thetaphi.de> wrote:
> Are we sure that this is the right thing? The LUCENE_MAIN_VERSION is used for index compatibility and should always be only in X.Y format.
>
> Please revert this!
>
Uwe is correct: please only adjust build.xml here or whatever, but
don't change this!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
RE: svn commit: r1482642 - /lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lucene/util/Constants.java
Posted by Uwe Schindler <uw...@thetaphi.de>.
Are we sure that this is the right thing? The LUCENE_MAIN_VERSION is used for index compatibility and should always be only in X.Y format.
Please revert this!
-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de
> -----Original Message-----
> From: hossman@apache.org [mailto:hossman@apache.org]
> Sent: Wednesday, May 15, 2013 1:41 AM
> To: commits@lucene.apache.org
> Subject: svn commit: r1482642 -
> /lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/l
> ucene/util/Constants.java
>
> Author: hossman
> Date: Tue May 14 23:41:23 2013
> New Revision: 1482642
>
> URL: http://svn.apache.org/r1482642
> Log:
> LUCENE-5001: update Constants.LUCENE_MAIN_VERSION for 4.3.1
>
> Modified:
>
> lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lu
> cene/util/Constants.java
>
> Modified:
> lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lu
> cene/util/Constants.java
> URL:
> http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_3/lucen
> e/core/src/java/org/apache/lucene/util/Constants.java?rev=1482642&r1=14
> 82641&r2=1482642&view=diff
> ==========================================================
> ====================
> ---
> lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lu
> cene/util/Constants.java (original)
> +++
> lucene/dev/branches/lucene_solr_4_3/lucene/core/src/java/org/apache/lu
> cene/util/Constants.java Tue May 14 23:41:23 2013
> @@ -122,7 +122,7 @@ public final class Constants {
> /**
> * This is the internal Lucene version, recorded into each segment.
> */
> - public static final String LUCENE_MAIN_VERSION = ident("4.3");
> + public static final String LUCENE_MAIN_VERSION = ident("4.3.1");
>
> /**
> * This is the Lucene version for display purposes.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org