You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/28 19:14:06 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9939: style(mypy): Enforcing typing for superset.views
codecov-commenter edited a comment on pull request #9939:
URL: https://github.com/apache/incubator-superset/pull/9939#issuecomment-635541586
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=h1) Report
> Merging [#9939](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9939/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9939 +/- ##
==========================================
- Coverage 71.31% 71.05% -0.26%
==========================================
Files 585 401 -184
Lines 30887 12738 -18149
Branches 3236 3236
==========================================
- Hits 22027 9051 -12976
+ Misses 8750 3578 -5172
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.94% <ø> (+0.10%)` | :arrow_up: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | | |
| [superset/views/chart/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvbWl4aW4ucHk=) | | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | | |
| [superset/queries/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/9939/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=footer). Last update [b296a0f...9e9d756](https://codecov.io/gh/apache/incubator-superset/pull/9939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org