You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/12/02 23:48:06 UTC

[GitHub] [hadoop] hadoop-yetus commented on pull request #2513: YARN-10494 CLI tool for docker-to-squashfs conversion (pure Java).

hadoop-yetus commented on pull request #2513:
URL: https://github.com/apache/hadoop/pull/2513#issuecomment-737564406


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   1m  5s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  |  No case conflicting files found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch appears to include 68 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  34m 58s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   2m 58s |  |  trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  compile  |   2m 13s |  |  trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   2m 17s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  20m  0s |  |  branch has no errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 41s |  |  trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  javadoc  |   1m 23s |  |  trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +0 :ok: |  spotbugs  |   5m 40s |  |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   5m 36s |  |  trunk passed  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 41s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  5s |  |  the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  javac  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 12s |  |  the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +1 :green_heart: |  javac  |   2m 12s |  |  the patch passed  |
   | -0 :warning: |  checkstyle  |   0m 44s | [/diff-checkstyle-hadoop-tools.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/artifact/out/diff-checkstyle-hadoop-tools.txt) |  hadoop-tools: The patch generated 399 new + 0 unchanged - 0 fixed = 399 total (was 0)  |
   | +1 :green_heart: |  mvnsite  |   2m 41s |  |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  xml  |   0m  2s |  |  The patch has no ill-formed XML file.  |
   | -1 :x: |  shadedclient  |   2m 22s |  |  patch has errors when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   2m  4s |  |  the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  javadoc  |   1m 40s |  |  the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | -1 :x: |  findbugs  |   5m 51s | [/new-findbugs-hadoop-tools.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/artifact/out/new-findbugs-hadoop-tools.html) |  hadoop-tools generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 27s |  |  hadoop-runc in the patch passed.  |
   | -1 :x: |  unit  |  54m 23s | [/patch-unit-hadoop-tools.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/artifact/out/patch-unit-hadoop-tools.txt) |  hadoop-tools in the patch passed.  |
   | -1 :x: |  asflicense  |   0m 29s | [/patch-asflicense-problems.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/artifact/out/patch-asflicense-problems.txt) |  The patch generated 6 ASF License warnings.  |
   |  |   | 153m 38s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-tools |
   |  |  Self assignment of field DockerClient.manifestChooser in org.apache.hadoop.runc.docker.DockerClient.setManifestChooser(ManifestChooser)  At DockerClient.java:in org.apache.hadoop.runc.docker.DockerClient.setManifestChooser(ManifestChooser)  At DockerClient.java:[line 94] |
   |  |  Inconsistent synchronization of org.apache.hadoop.runc.docker.auth.BearerCredentials.token; locked 66% of time  Unsynchronized access at BearerCredentials.java:66% of time  Unsynchronized access at BearerCredentials.java:[line 65] |
   |  |  Class org.apache.hadoop.runc.docker.auth.BearerScheme defines non-transient non-serializable instance field client  In BearerScheme.java:instance field client  In BearerScheme.java |
   |  |  org.apache.hadoop.runc.docker.model.ManifestListV2.CONTENT_TYPE isn't final but should be  At ManifestListV2.java:be  At ManifestListV2.java:[line 14] |
   |  |  org.apache.hadoop.runc.docker.model.ManifestV2.CONTENT_TYPE isn't final but should be  At ManifestV2.java:be  At ManifestV2.java:[line 14] |
   |  |  Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.runc.squashfs.SquashFsTree.build()  At SquashFsTree.java:then immediately reboxed in org.apache.hadoop.runc.squashfs.SquashFsTree.build()  At SquashFsTree.java:[line 140] |
   |  |  org.apache.hadoop.runc.squashfs.data.DataBlock.getData() may expose internal representation by returning DataBlock.data  At DataBlock.java:by returning DataBlock.data  At DataBlock.java:[line 28] |
   |  |  new org.apache.hadoop.runc.squashfs.data.DataBlock(byte[], int, int) may expose internal representation by storing an externally mutable object into DataBlock.data  At DataBlock.java:expose internal representation by storing an externally mutable object into DataBlock.data  At DataBlock.java:[line 44] |
   |  |  Increment of volatile field org.apache.hadoop.runc.squashfs.data.DataBlockCache.cacheHits in org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At DataBlockCache.java:in org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At DataBlockCache.java:[line 53] |
   |  |  Increment of volatile field org.apache.hadoop.runc.squashfs.data.DataBlockCache.cacheMisses in org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At DataBlockCache.java:in org.apache.hadoop.runc.squashfs.data.DataBlockCache.get(DataBlockCache$Key)  At DataBlockCache.java:[line 47] |
   |  |  org.apache.hadoop.runc.squashfs.directory.DirectoryEntry.getName() may expose internal representation by returning DirectoryEntry.name  At DirectoryEntry.java:by returning DirectoryEntry.name  At DirectoryEntry.java:[line 67] |
   |  |  org.apache.hadoop.runc.squashfs.inode.BasicFileINode.getBlockSizes() may expose internal representation by returning BasicFileINode.blockSizes  At BasicFileINode.java:by returning BasicFileINode.blockSizes  At BasicFileINode.java:[line 190] |
   |  |  org.apache.hadoop.runc.squashfs.inode.BasicFileINode.setBlockSizes(int[]) may expose internal representation by storing an externally mutable object into BasicFileINode.blockSizes  At BasicFileINode.java:by storing an externally mutable object into BasicFileINode.blockSizes  At BasicFileINode.java:[line 195] |
   |  |  org.apache.hadoop.runc.squashfs.inode.BasicSymlinkINode.getTargetPath() may expose internal representation by returning BasicSymlinkINode.targetPath  At BasicSymlinkINode.java:by returning BasicSymlinkINode.targetPath  At BasicSymlinkINode.java:[line 68] |
   |  |  org.apache.hadoop.runc.squashfs.inode.ExtendedFileINode.getBlockSizes() may expose internal representation by returning ExtendedFileINode.blockSizes  At ExtendedFileINode.java:by returning ExtendedFileINode.blockSizes  At ExtendedFileINode.java:[line 85] |
   |  |  org.apache.hadoop.runc.squashfs.inode.ExtendedFileINode.setBlockSizes(int[]) may expose internal representation by storing an externally mutable object into ExtendedFileINode.blockSizes  At ExtendedFileINode.java:by storing an externally mutable object into ExtendedFileINode.blockSizes  At ExtendedFileINode.java:[line 90] |
   |  |  org.apache.hadoop.runc.squashfs.inode.ExtendedSymlinkINode.getTargetPath() may expose internal representation by returning ExtendedSymlinkINode.targetPath  At ExtendedSymlinkINode.java:by returning ExtendedSymlinkINode.targetPath  At ExtendedSymlinkINode.java:[line 53] |
   |  |  new org.apache.hadoop.runc.squashfs.metadata.MemoryMetadataBlockReader(int, SuperBlock, byte[], int, int) may expose internal representation by storing an externally mutable object into MemoryMetadataBlockReader.data  At MemoryMetadataBlockReader.java:int) may expose internal representation by storing an externally mutable object into MemoryMetadataBlockReader.data  At MemoryMetadataBlockReader.java:[line 45] |
   |  |  org.apache.hadoop.runc.squashfs.metadata.MetadataBlock.getData() may expose internal representation by returning MetadataBlock.data  At MetadataBlock.java:by returning MetadataBlock.data  At MetadataBlock.java:[line 63] |
   |  |  new org.apache.hadoop.runc.squashfs.table.MemoryTableReader(SuperBlock, byte[], int, int) may expose internal representation by storing an externally mutable object into MemoryTableReader.data  At MemoryTableReader.java:may expose internal representation by storing an externally mutable object into MemoryTableReader.data  At MemoryTableReader.java:[line 41] |
   |  |  Boxing/unboxing to parse a primitive org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[])  At SquashDebug.java:org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[])  At SquashDebug.java:[line 195] |
   |  |  Boxing/unboxing to parse a primitive org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[])  At SquashDebug.java:org.apache.hadoop.runc.squashfs.util.SquashDebug.run(String[])  At SquashDebug.java:[line 194] |
   |  |  Possible null pointer dereference in org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File) due to return value of called method  Dereferenced at ImportDockerImage.java:org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File) due to return value of called method  Dereferenced at ImportDockerImage.java:[line 472] |
   |  |  Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File)  At ImportDockerImage.java:ignored in org.apache.hadoop.runc.tools.ImportDockerImage.deleteRecursive(File)  At ImportDockerImage.java:[line 476] |
   |  |  Exceptional return value of java.io.File.mkdirs() ignored in org.apache.hadoop.runc.tools.ImportDockerImage.importDockerImage(String, String)  At ImportDockerImage.java:ignored in org.apache.hadoop.runc.tools.ImportDockerImage.importDockerImage(String, String)  At ImportDockerImage.java:[line 201] |
   | Failed junit tests | hadoop.tools.dynamometer.TestDynamometerInfra |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2513 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle |
   | uname | Linux 4c6b91f6eada 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 2b5b556dd7f |
   | Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
   | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/testReport/ |
   | Max. process+thread count | 999 (vs. ulimit of 5500) |
   | modules | C: hadoop-tools/hadoop-runc hadoop-tools U: hadoop-tools |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2513/1/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org