You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/12/07 08:27:50 UTC

[GitHub] [sling-org-apache-sling-testing-sling-mock-oak] kwin commented on a change in pull request #5: SLING-10972 shade Guava

kwin commented on a change in pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5#discussion_r763743396



##########
File path: pom.xml
##########
@@ -181,6 +181,7 @@
                     <artifactSet>
                         <includes>
                             <include>org.apache.jackrabbit:*</include>
+                            <include>com.google.guava:*</include>

Review comment:
       Relocation does work (as long as the embedded Oak version is used). I therefore relocated in https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/5/commits/bdf07b00070b71c5eb2d3a23aa7302300df173ab. That way the order of the class path does not matter.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org