You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2013/12/19 00:29:45 UTC
Review Request 16357: Patch for KAFKA-1185
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16357/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1185
https://issues.apache.org/jira/browse/KAFKA-1185
Repository: kafka
Description
-------
1) Included a new API that allows the current leader to resign 2) Changed controller to correctly initialize its data structures on resigning as controller
Diffs
-----
core/src/main/scala/kafka/controller/KafkaController.scala 965d0e56b5a5b10953904235034e974a5b658321
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala cc6f1eba291c113a1b84259441efc1b64463affe
Diff: https://reviews.apache.org/r/16357/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 16357: Patch for KAFKA-1185
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16357/#review30764
-----------------------------------------------------------
Ship it!
Ship It!
- Jun Rao
On Dec. 20, 2013, 12:47 a.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16357/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2013, 12:47 a.m.)
>
>
> Review request for kafka and Jun Rao.
>
>
> Bugs: KAFKA-1185
> https://issues.apache.org/jira/browse/KAFKA-1185
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's review comment
>
>
> 1) Included a new API that allows the current leader to resign 2) Changed controller to correctly initialize its data structures on resigning as controller
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala 965d0e56b5a5b10953904235034e974a5b658321
> core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala cc6f1eba291c113a1b84259441efc1b64463affe
>
> Diff: https://reviews.apache.org/r/16357/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16357: Patch for KAFKA-1185
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16357/
-----------------------------------------------------------
(Updated Dec. 20, 2013, 12:47 a.m.)
Review request for kafka and Jun Rao.
Changes
-------
Need review from Jun to be able to commit
Bugs: KAFKA-1185
https://issues.apache.org/jira/browse/KAFKA-1185
Repository: kafka
Description
-------
Addressed Guozhang's review comment
1) Included a new API that allows the current leader to resign 2) Changed controller to correctly initialize its data structures on resigning as controller
Diffs
-----
core/src/main/scala/kafka/controller/KafkaController.scala 965d0e56b5a5b10953904235034e974a5b658321
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala cc6f1eba291c113a1b84259441efc1b64463affe
Diff: https://reviews.apache.org/r/16357/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 16357: Patch for KAFKA-1185
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16357/#review30724
-----------------------------------------------------------
Ship it!
- Guozhang Wang
On Dec. 19, 2013, 9:57 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16357/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 9:57 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1185
> https://issues.apache.org/jira/browse/KAFKA-1185
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's review comment
>
>
> 1) Included a new API that allows the current leader to resign 2) Changed controller to correctly initialize its data structures on resigning as controller
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala 965d0e56b5a5b10953904235034e974a5b658321
> core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala cc6f1eba291c113a1b84259441efc1b64463affe
>
> Diff: https://reviews.apache.org/r/16357/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 16357: Patch for KAFKA-1185
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16357/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 9:57 p.m.)
Review request for kafka.
Bugs: KAFKA-1185
https://issues.apache.org/jira/browse/KAFKA-1185
Repository: kafka
Description (updated)
-------
Addressed Guozhang's review comment
1) Included a new API that allows the current leader to resign 2) Changed controller to correctly initialize its data structures on resigning as controller
Diffs (updated)
-----
core/src/main/scala/kafka/controller/KafkaController.scala 965d0e56b5a5b10953904235034e974a5b658321
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala cc6f1eba291c113a1b84259441efc1b64463affe
Diff: https://reviews.apache.org/r/16357/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 16357: Patch for KAFKA-1185
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16357/#review30658
-----------------------------------------------------------
The new api function will be called whenever the current registration path data is deleted, no matter whether the current broker is the elected leader. That is not natural to be used as a resignation API do you think?
- Guozhang Wang
On Dec. 18, 2013, 11:29 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16357/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 11:29 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1185
> https://issues.apache.org/jira/browse/KAFKA-1185
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1) Included a new API that allows the current leader to resign 2) Changed controller to correctly initialize its data structures on resigning as controller
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala 965d0e56b5a5b10953904235034e974a5b658321
> core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala cc6f1eba291c113a1b84259441efc1b64463affe
>
> Diff: https://reviews.apache.org/r/16357/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>