You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/25 07:58:09 UTC
[GitHub] [incubator-mxnet] rondogency opened a new pull request #18167: Custom Operator Perf Script and Error Message
rondogency opened a new pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167
## Description ##
Some minor improvement to C++ custom operator, optionally can go into 1.7
Add reproducible performance test script and improve some error messages. It is an address of comments from PR #17885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] rondogency commented on pull request #18167: Custom Operator Perf Script and Error Message
Posted by GitBox <gi...@apache.org>.
rondogency commented on pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167#issuecomment-619443012
@ciyongch after discussion I decide to change this PR to only modify docs and examples and merge it later, so that it won't need to go into 1.7 (no change to binary). You can ignore this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18167: Custom Operator Perf Script and Error Message
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167#issuecomment-680317252
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18167: Custom Operator Perf Script and Error Message
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167#issuecomment-680317296
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, edge, unix-cpu, website, windows-gpu, windows-cpu, unix-gpu, sanity, clang, miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] rondogency commented on pull request #18167: Custom Operator Perf Script and Error Message
Posted by GitBox <gi...@apache.org>.
rondogency commented on pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167#issuecomment-619338888
@ciyongch Can you tell you if the backport happens on 4.25 11:59 pm? If it is then I can backport this to 1.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18167: Custom Operator Perf Script and Error Message
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167#issuecomment-619461733
Ok, then I'll not track this PR in the release, thanks for the update :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18167: Custom Operator Perf Script and Error Message
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18167:
URL: https://github.com/apache/incubator-mxnet/pull/18167#issuecomment-619358009
@rondogency yes, the code freeze will be 4/25 11:59 pm PST. Please arrange your time for this patch, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org