You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/31 15:59:20 UTC

[GitHub] [spark] srowen commented on pull request #35078: [SPARK-37796][SQL] ByteArrayMethods arrayEquals should fast skip the check of aligning with unaligned platform

srowen commented on pull request #35078:
URL: https://github.com/apache/spark/pull/35078#issuecomment-1003407074


   I find that fairly convincing for x86. I'm worried about ARM - not just performance but correctness. ARMv7 supports unaligned access; ARMv5 does not. But v7 seems to have some 'gotchas' that direct access like this may hit. 
   
   If ARM JDKs show up as 'aligned' then I think this is fine, but that's what I don't know right now. Do you have any easy way to check that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org