You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/04 18:41:37 UTC

[GitHub] [incubator-tvm] merrymercy commented on issue #4749: [AutoTVM] Support to pass additional compiler options

merrymercy commented on issue #4749: [AutoTVM] Support to pass additional compiler options
URL: https://github.com/apache/incubator-tvm/pull/4749#issuecomment-582055130
 
 
   1. We should not put `options` in `MeasureResult`. It is not result (output). It is input.
   2. If you change MeasureInput / MeasureResult, you should also update serialization for them in `python/tvm/autotvm/record.py::encode, decode`. You should be very careful about the backward-compatibility.
   3. If you add `options` to records, why don't you also add `build_func`?
   
   Currently, I think not serializing them is fine. Or we can embed `options` into `MeasureInput.task` and serialize them carefully.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services