You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2016/03/02 11:17:04 UTC
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/1753
[build] Consolidate scala checkstyle usage and update version to 0.8.0
Consolidation is done via plugin management, so that configuration is done in one central location.
Version update is needed because the latest releaseof the plugin, 0.8.0 contains a fix for a bug that I have recently run into. [1]
[1] https://github.com/scalastyle/scalastyle/pull/124
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink scalastyle-bump
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1753.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1753
----
commit 2abfb63bbab0e511bcdd680593b310ccc9f98da0
Author: Márton Balassi <mb...@apache.org>
Date: 2016-03-01T20:42:40Z
[build] Consolidate scala checkstyle usage and update version to 0.8.0
Consolidation is done via plugin management.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1753
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-193707660
If no objections I would like to merge this Friday morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-195285363
Great wish, my pleasure to grant it. :smile:
Merging as soon as travis goes through.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-195003250
+1, looks good to me
A minor "wish" from my side: I like it to not have generated files in the project directories, so I'd suggest to change the output file path to put the file into the "target" dir:
```xml
<outputFile>${project.basedir}/target/scalastyle-output.xml</outputFile>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-191792667
Changes seem not to be complete. Travis test cases fail because of "Unable to find configuration file at location /home/travis/build/apache/flink/flink-yarn-tests/../../tools/maven/scalastyle-config.xml"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [build] Consolidate scala checkstyle usage and...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1753#issuecomment-191797058
Thanks or catching it, pushed the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---