[jira] [Commented] (CB-1193) Weinre: add Windows Phone support

["Sergey Grebnov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498744#comment-13498744 ] 

Sergey Grebnov commented on CB-1193:
------------------------------------

Hi Patrick, I've addressed your review comments, please take a look
https://github.com/apache/incubator-cordova-weinre/pull/9

According to 'weinre.build/vendor' problem I've created 'vendor-override' folder as you suggested with the single InjectedScriptSource.js file. It is the only file required for the target script, other files could be overwritten (they only contains 'const->var' improvement which is not required for the target script). If we add support of non-webkit browsers for the client component then we will have to add all those files to the vendor-override folder, but for now let's keep it as simple as possible.

I've also double checked "matchesSelector" - WP7(IE9) supports it only with ms vendor prefix.
                
> Weinre: add Windows Phone support
> ---------------------------------
>
>                 Key: CB-1193
>                 URL: https://issues.apache.org/jira/browse/CB-1193
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: weinre
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: weinre, windows
>
> Since Windows Phone does not provide any html debug possibilities it will be great to support it via Weinre remote debugger.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira