You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@gmail.com> on 2020/01/20 20:40:43 UTC

Migrating from Travis CI to GitHub Actions

Given GitHub has introduced its own CI, i.e., GitHub Actions, would
you consider migrating from Travis CI to that? In its current form,
setup-java[1] doesn't support multiple JDKs, but I think it can be
worked around. If the rest of the people would agree, I will create a
ticket for that and work on it after "replacing JsonLayout with
LogstashLayout" task, which I am currently busy right now.

Advantages? Technically none, socially a more GitHub-friendly project setup.

[1] https://github.com/actions/setup-java/

Re: Migrating from Travis CI to GitHub Actions

Posted by Volkan Yazıcı <vo...@gmail.com>.
Good point! setup-java "action" also supports[1] `-ea` suffix in versions:

A major Java version
  e.g. 6, 7, 8, 9, 10, 11, 12, 13, ...

A semver Java version specification
  e.g. 8.0.232, 7.0.181, 11.0.4
  e.g. 8.0.x, >11.0.3, >=13.0.1, <8.0.212

An early access (EA) Java version
  e.g. 14-ea, 15-ea
  e.g. 14.0.0-ea, 15.0.0-ea
  e.g. 14.0.0-ea.28, 15.0.0-ea.2 (syntax for specifying an EA build number)

Note that, per semver rules, EA builds will be matched by explicit EA
version specifications.

1.x syntax
  e.g. 1.8 (same as 8)
  e.g. 1.8.0.212 (same as 8.0.212)

Kind regards.

[1] https://github.com/actions/setup-java#basic

On Wed, Jul 1, 2020 at 5:44 PM Gary Gregory <ga...@gmail.com> wrote:
>
> In Travis-CI, you can say "java-ea", what is the equivalent in GitHub?
>
> Gary
>
> On Wed, Jul 1, 2020 at 9:33 AM Matt Sicker <bo...@gmail.com> wrote:
>
> > I’ll take a look this week sometime. I’m in support of everything said
> > here, too. This should help the PR testing feature actually work again!
> >
> > On Wed, Jul 1, 2020 at 06:49 Volkan Yazıcı <vo...@gmail.com>
> > wrote:
> >
> > > Hello,
> > >
> > > I have pulled this off in my local repo and created a PR[1]. If there
> > > are no objections, I really would like to get this merged. Once this
> > > lifts off, I am inclined to drop the Travis CI. Would anybody mind
> > > reviewing the PR, please? (Note that the change set updates the Maven
> > > Wrapper scripts too.)
> > >
> > > Cheers!
> > >
> > > [1] https://github.com/apache/logging-log4j2/pull/379
> > >
> > > On Mon, Jan 20, 2020 at 9:40 PM Volkan Yazıcı <vo...@gmail.com>
> > > wrote:
> > > >
> > > > Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> > > > you consider migrating from Travis CI to that? In its current form,
> > > > setup-java[1] doesn't support multiple JDKs, but I think it can be
> > > > worked around. If the rest of the people would agree, I will create a
> > > > ticket for that and work on it after "replacing JsonLayout with
> > > > LogstashLayout" task, which I am currently busy right now.
> > > >
> > > > Advantages? Technically none, socially a more GitHub-friendly project
> > > setup.
> > > >
> > > > [1] https://github.com/actions/setup-java/
> > >
> > --
> > Matt Sicker <bo...@gmail.com>
> >

Re: Migrating from Travis CI to GitHub Actions

Posted by Gary Gregory <ga...@gmail.com>.
In Travis-CI, you can say "java-ea", what is the equivalent in GitHub?

Gary

On Wed, Jul 1, 2020 at 9:33 AM Matt Sicker <bo...@gmail.com> wrote:

> I’ll take a look this week sometime. I’m in support of everything said
> here, too. This should help the PR testing feature actually work again!
>
> On Wed, Jul 1, 2020 at 06:49 Volkan Yazıcı <vo...@gmail.com>
> wrote:
>
> > Hello,
> >
> > I have pulled this off in my local repo and created a PR[1]. If there
> > are no objections, I really would like to get this merged. Once this
> > lifts off, I am inclined to drop the Travis CI. Would anybody mind
> > reviewing the PR, please? (Note that the change set updates the Maven
> > Wrapper scripts too.)
> >
> > Cheers!
> >
> > [1] https://github.com/apache/logging-log4j2/pull/379
> >
> > On Mon, Jan 20, 2020 at 9:40 PM Volkan Yazıcı <vo...@gmail.com>
> > wrote:
> > >
> > > Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> > > you consider migrating from Travis CI to that? In its current form,
> > > setup-java[1] doesn't support multiple JDKs, but I think it can be
> > > worked around. If the rest of the people would agree, I will create a
> > > ticket for that and work on it after "replacing JsonLayout with
> > > LogstashLayout" task, which I am currently busy right now.
> > >
> > > Advantages? Technically none, socially a more GitHub-friendly project
> > setup.
> > >
> > > [1] https://github.com/actions/setup-java/
> >
> --
> Matt Sicker <bo...@gmail.com>
>

Re: Migrating from Travis CI to GitHub Actions

Posted by Matt Sicker <bo...@gmail.com>.
I’ll take a look this week sometime. I’m in support of everything said
here, too. This should help the PR testing feature actually work again!

On Wed, Jul 1, 2020 at 06:49 Volkan Yazıcı <vo...@gmail.com> wrote:

> Hello,
>
> I have pulled this off in my local repo and created a PR[1]. If there
> are no objections, I really would like to get this merged. Once this
> lifts off, I am inclined to drop the Travis CI. Would anybody mind
> reviewing the PR, please? (Note that the change set updates the Maven
> Wrapper scripts too.)
>
> Cheers!
>
> [1] https://github.com/apache/logging-log4j2/pull/379
>
> On Mon, Jan 20, 2020 at 9:40 PM Volkan Yazıcı <vo...@gmail.com>
> wrote:
> >
> > Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> > you consider migrating from Travis CI to that? In its current form,
> > setup-java[1] doesn't support multiple JDKs, but I think it can be
> > worked around. If the rest of the people would agree, I will create a
> > ticket for that and work on it after "replacing JsonLayout with
> > LogstashLayout" task, which I am currently busy right now.
> >
> > Advantages? Technically none, socially a more GitHub-friendly project
> setup.
> >
> > [1] https://github.com/actions/setup-java/
>
-- 
Matt Sicker <bo...@gmail.com>

Re: Migrating from Travis CI to GitHub Actions

Posted by Volkan Yazıcı <vo...@gmail.com>.
Hello,

I have pulled this off in my local repo and created a PR[1]. If there
are no objections, I really would like to get this merged. Once this
lifts off, I am inclined to drop the Travis CI. Would anybody mind
reviewing the PR, please? (Note that the change set updates the Maven
Wrapper scripts too.)

Cheers!

[1] https://github.com/apache/logging-log4j2/pull/379

On Mon, Jan 20, 2020 at 9:40 PM Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> you consider migrating from Travis CI to that? In its current form,
> setup-java[1] doesn't support multiple JDKs, but I think it can be
> worked around. If the rest of the people would agree, I will create a
> ticket for that and work on it after "replacing JsonLayout with
> LogstashLayout" task, which I am currently busy right now.
>
> Advantages? Technically none, socially a more GitHub-friendly project setup.
>
> [1] https://github.com/actions/setup-java/

Re: Migrating from Travis CI to GitHub Actions

Posted by Volkan Yazıcı <vo...@gmail.com>.
Given everybody is willing to give it a go, I've created LOG4J2-2764[1].

[1] https://issues.apache.org/jira/browse/LOG4J2-2764

On Mon, Jan 20, 2020 at 9:40 PM Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> you consider migrating from Travis CI to that? In its current form,
> setup-java[1] doesn't support multiple JDKs, but I think it can be
> worked around. If the rest of the people would agree, I will create a
> ticket for that and work on it after "replacing JsonLayout with
> LogstashLayout" task, which I am currently busy right now.
>
> Advantages? Technically none, socially a more GitHub-friendly project setup.
>
> [1] https://github.com/actions/setup-java/

Re: Migrating from Travis CI to GitHub Actions

Posted by Ralph Goers <ra...@dslextreme.com>.
I don’t think we need 3 build systems. I would be open to adding the support for GitHub Actions and then deciding if it is easier to work with than Travis.

Ralph

> On Jan 20, 2020, at 3:40 PM, Gary Gregory <ga...@gmail.com> wrote:
> 
> FWIW, over at Apache Commons, some components use both.
> 
> Gary
> 
> On Mon, Jan 20, 2020 at 3:42 PM Matt Sicker <bo...@gmail.com> wrote:
> 
>> I'd be on board with trying that out as an alternative to Travis.
>> Anything to help test PRs more reliably is great, especially without
>> having to overload our Jenkins instance (which is already running CI
>> on master and 2.x).
>> 
>> On Mon, 20 Jan 2020 at 14:39, Volkan Yazıcı <vo...@gmail.com>
>> wrote:
>>> 
>>> Given GitHub has introduced its own CI, i.e., GitHub Actions, would
>>> you consider migrating from Travis CI to that? In its current form,
>>> setup-java[1] doesn't support multiple JDKs, but I think it can be
>>> worked around. If the rest of the people would agree, I will create a
>>> ticket for that and work on it after "replacing JsonLayout with
>>> LogstashLayout" task, which I am currently busy right now.
>>> 
>>> Advantages? Technically none, socially a more GitHub-friendly project
>> setup.
>>> 
>>> [1] https://github.com/actions/setup-java/
>> 
>> 
>> 
>> --
>> Matt Sicker <bo...@gmail.com>
>> 



Re: Migrating from Travis CI to GitHub Actions

Posted by Gary Gregory <ga...@gmail.com>.
FWIW, over at Apache Commons, some components use both.

Gary

On Mon, Jan 20, 2020 at 3:42 PM Matt Sicker <bo...@gmail.com> wrote:

> I'd be on board with trying that out as an alternative to Travis.
> Anything to help test PRs more reliably is great, especially without
> having to overload our Jenkins instance (which is already running CI
> on master and 2.x).
>
> On Mon, 20 Jan 2020 at 14:39, Volkan Yazıcı <vo...@gmail.com>
> wrote:
> >
> > Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> > you consider migrating from Travis CI to that? In its current form,
> > setup-java[1] doesn't support multiple JDKs, but I think it can be
> > worked around. If the rest of the people would agree, I will create a
> > ticket for that and work on it after "replacing JsonLayout with
> > LogstashLayout" task, which I am currently busy right now.
> >
> > Advantages? Technically none, socially a more GitHub-friendly project
> setup.
> >
> > [1] https://github.com/actions/setup-java/
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>

Re: Migrating from Travis CI to GitHub Actions

Posted by Matt Sicker <bo...@gmail.com>.
I'd be on board with trying that out as an alternative to Travis.
Anything to help test PRs more reliably is great, especially without
having to overload our Jenkins instance (which is already running CI
on master and 2.x).

On Mon, 20 Jan 2020 at 14:39, Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Given GitHub has introduced its own CI, i.e., GitHub Actions, would
> you consider migrating from Travis CI to that? In its current form,
> setup-java[1] doesn't support multiple JDKs, but I think it can be
> worked around. If the rest of the people would agree, I will create a
> ticket for that and work on it after "replacing JsonLayout with
> LogstashLayout" task, which I am currently busy right now.
>
> Advantages? Technically none, socially a more GitHub-friendly project setup.
>
> [1] https://github.com/actions/setup-java/



-- 
Matt Sicker <bo...@gmail.com>