[GitHub] [arrow] westonpace commented on a diff in pull request #13686: ARROW-15938: [C++][Compute] Fixing HashJoinBasicImpl in case of zero batches on build side

[GitBox <gi...@apache.org>]

westonpace commented on code in PR #13686:
URL: https://github.com/apache/arrow/pull/13686#discussion_r929426092


##########
cpp/src/arrow/compute/exec/hash_join_node_test.cc:
##########
@@ -1298,6 +1298,15 @@ void TestHashJoinDictionaryHelper(
     }
   }
 
+  // Instead of sending 2 batches of size 0 we should not send any batches
+  // at all to more accurately simulate real world use cases
+  if (l_length == 0) {
+    l_batches.batches.resize(0);
+  }
+  if (r_length == 0) {
+    r_batches.batches.resize(0);
+  }
+

Review Comment:
   Since we now handle both cases (no batches and only empty batches) can we test both scenarios?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org