[GitHub] rafaelweingartner commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function
URL: https://github.com/apache/cloudstack/pull/2580#discussion_r182544640
 
 

 ##########
 File path: plugins/dedicated-resources/src/main/java/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
 ##########
 @@ -497,7 +497,7 @@ public boolean configure(final String name, final Map<String, Object> params) th
                     }
                     dedicatedResource = _dedicatedDao.persist(dedicatedResource);
                 } catch (Exception e) {
-                    s_logger.error("Unable to dedicate host due to " + e.getMessage(), e);
+                    s_logger.error("Unable to dedicate cluster due to " + e.getMessage(), e);
                     throw new CloudRuntimeException("Failed to dedicate cluster. Please contact Cloud Support.");
 
 Review comment:
   What about passing the `e` to the `CloudRuntimeException`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services