You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/31 00:00:48 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7303:
[AIRFLOW-6691][depends on AIFLOW-6680] Add tests that protect the
deprecated packages
mik-laj opened a new pull request #7303: [AIRFLOW-6691][depends on AIFLOW-6680] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303
Some people may mistakenly add new changes to a package that is depreccated. We should detect this to avoid confusion and notify the contributor.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7303: [AIRFLOW-6691] Add
tests that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#issuecomment-581180885
It's is unrelated changes. https://github.com/apache/airflow/pull/7309#issuecomment-581180347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7303:
[AIRFLOW-6691] Add tests that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#discussion_r373875413
##########
File path: tests/test_project_structure.py
##########
@@ -23,15 +23,29 @@
ROOT_FOLDER = os.path.realpath(
os.path.join(os.path.dirname(os.path.realpath(__file__)), os.pardir)
)
-CORE_EXAMPLE_DAGS_FOLDER = os.path.join(ROOT_FOLDER, "airflow", "example_dags")
-class TestExampleDags(unittest.TestCase):
- def test_reference_to_providers_is_illegal(self):
- for filename in glob.glob(f"{CORE_EXAMPLE_DAGS_FOLDER}/**.py"):
+class TestProjectStructure(unittest.TestCase):
+ def test_reference_to_providers_from_core(self):
+ for filename in glob.glob(f"{ROOT_FOLDER}/example_dagss/**.py", recursive=True):
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7303:
[AIRFLOW-6691] Add tests that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#discussion_r373874920
##########
File path: tests/test_project_structure.py
##########
@@ -23,15 +23,29 @@
ROOT_FOLDER = os.path.realpath(
os.path.join(os.path.dirname(os.path.realpath(__file__)), os.pardir)
)
-CORE_EXAMPLE_DAGS_FOLDER = os.path.join(ROOT_FOLDER, "airflow", "example_dags")
-class TestExampleDags(unittest.TestCase):
- def test_reference_to_providers_is_illegal(self):
- for filename in glob.glob(f"{CORE_EXAMPLE_DAGS_FOLDER}/**.py"):
+class TestProjectStructure(unittest.TestCase):
+ def test_reference_to_providers_from_core(self):
+ for filename in glob.glob(f"{ROOT_FOLDER}/example_dagss/**.py", recursive=True):
Review comment:
```suggestion
for filename in glob.glob(f"{ROOT_FOLDER}/example_dags/**.py", recursive=True):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7303: [AIRFLOW-6691] Add
tests that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7303: [AIRFLOW-6691]
Add tests that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#issuecomment-581180936
Awesome @coopergillan is already working on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7303: [AIRFLOW-6691] Add tests
that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#issuecomment-581180627
Static check failures :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7303: [AIRFLOW-6691] Add
tests that protect the deprecated packages
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#issuecomment-581180936
Awesome @coopergillan is working on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services