[GitHub] [activemq-website] cshannon commented on a change in pull request #74: [AMQ-8412] Update doc for maxFrameSizeEnabled check

[GitBox <gi...@apache.org>]

cshannon commented on a change in pull request #74:
URL: https://github.com/apache/activemq-website/pull/74#discussion_r800574709



##########
File path: src/configuring-wire-formats.md
##########
@@ -18,6 +18,7 @@ Option|Default|Description
 `maxInactivityDuration`|`30000`|The maximum [inactivity](activemq-inactivitymonitor) duration (before which the socket is considered dead) in milliseconds. On some platforms it can take a long time for a socket to die. Therefore allow the broker to kill connections when they have been inactive for the configured period of time. Used by some transports to enable a keep alive heart beat feature. Inactivity monitoring is disabled when set to a value `<= 0`.
 `maxInactivityDurationInitalDelay`|`10000`|The initial delay before starting [inactivity](activemq-inactivitymonitor) checks. Yes, the word `'Inital'` is supposed to be misspelled like that.
 `maxFrameSize`|`MAX_LONG`|Maximum allowed frame size. Can help help prevent OOM DOS attacks.

Review comment:
       I would update this description to mention this setting applies to both client and server side but that the minimum value is chosen so a client can't pick a larger value than the server, etc. Also you could mention here that as of 5.16.4 the size is checked client side by default unless maxFrameSizeEnabled is false (and obviously your other update describes what the flag does)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org