You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rp...@apache.org on 2013/06/06 16:03:28 UTC
svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c
Author: rpluem
Date: Thu Jun 6 14:03:28 2013
New Revision: 1490290
URL: http://svn.apache.org/r1490290
Log:
* truncpw was allocated from a pool and not via malloc
Modified:
httpd/httpd/trunk/modules/lua/lua_passwd.c
Modified: httpd/httpd/trunk/modules/lua/lua_passwd.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_passwd.c?rev=1490290&r1=1490289&r2=1490290&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/lua/lua_passwd.c (original)
+++ httpd/httpd/trunk/modules/lua/lua_passwd.c Thu Jun 6 14:03:28 2013
@@ -138,7 +138,6 @@ int mk_password_hash(passwd_ctx *ctx)
"characters by CRYPT algorithm.");
}
memset(truncpw, '\0', strlen(pw));
- free(truncpw);
}
break;
#endif /* CRYPT_ALGO_SUPPORTED */
Re: svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c
Posted by Marion & Christophe JAILLET <ch...@wanadoo.fr>.
Correct.
This was introduced in r1465115.
Fixed in trunk in r1490507.
Le 06/06/2013 17:54, Guenter Knauf a écrit :
> ua/lua_passwd.c T
Re: svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c
Posted by Guenter Knauf <fu...@apache.org>.
Hi Rüdiger,
On 06.06.2013 16:03, rpluem@apache.org wrote:
> Author: rpluem
> Date: Thu Jun 6 14:03:28 2013
> New Revision: 1490290
>
> URL: http://svn.apache.org/r1490290
> Log:
> * truncpw was allocated from a pool and not via malloc
>
> Modified:
> httpd/httpd/trunk/modules/lua/lua_passwd.c
>
> Modified: httpd/httpd/trunk/modules/lua/lua_passwd.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_passwd.c?rev=1490290&r1=1490289&r2=1490290&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/lua/lua_passwd.c (original)
> +++ httpd/httpd/trunk/modules/lua/lua_passwd.c Thu Jun 6 14:03:28 2013
> @@ -138,7 +138,6 @@ int mk_password_hash(passwd_ctx *ctx)
> "characters by CRYPT algorithm.");
> }
> memset(truncpw, '\0', strlen(pw));
> - free(truncpw);
> }
> break;
> #endif /* CRYPT_ALGO_SUPPORTED */
doesnt the same then also apply to ./support/passwd_common.c line 241 ?
Gün.