You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "derrickaw (via GitHub)" <gi...@apache.org> on 2026/05/01 18:09:25 UTC
[PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
derrickaw opened a new pull request, #38358:
URL: https://github.com/apache/beam/pull/38358
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38358:
URL: https://github.com/apache/beam/pull/38358#discussion_r3178552814
##########
sdks/python/setup.py:
##########
@@ -500,9 +500,10 @@ def get_portability_package_data():
'requests_mock>=1.7,<2.0',
# google-adk 1.28+ requires tenacity>=9,<10 (conflicts with <9).
'tenacity>=8.0.0,<10',
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38358:
URL: https://github.com/apache/beam/pull/38358#issuecomment-4365337213
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on aligning the Python SDK's dependency requirements with recent changes and proposed updates. By synchronizing these versions across multiple configuration files, the changes ensure that the environment remains stable and compatible with the latest project requirements, while also addressing specific versioning needs identified in related pull requests.
### Highlights
* **Dependency Synchronization**: Synchronized base requirements and setup configurations to ensure consistency across the project.
* **Version Updates**: Updated various Python package versions, including core libraries like `aiohttp`, `build`, `cryptography`, and `pytest` to align with recent changes and proposed requirements.
* **Configuration Adjustments**: Updated `pyproject.toml` and `build.gradle` to reflect new version constraints for `Jinja2` and `PyYAML`.
🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38358:
URL: https://github.com/apache/beam/pull/38358#discussion_r3177594848
##########
sdks/python/setup.py:
##########
@@ -656,7 +657,7 @@ def get_portability_package_data():
],
'ml_cpu': [
'tensorflow>=2.12.0',
- 'torch==2.8.0+cpu',
+ 'torch==2.8.0',
Review Comment:
There is an inconsistency between this pin and the generated requirements for Python 3.12 (`sdks/python/container/ml/py312/base_image_requirements.txt`), which now uses `torch==2.8.0+cpu`. Removing the `+cpu` suffix here while adding it in the frozen requirements can lead to installation issues or mismatched environments in the ML containers.
```suggestion
'torch==2.8.0+cpu',
```
##########
sdks/python/setup.py:
##########
@@ -206,13 +206,13 @@ def cythonize(*args, **kwargs):
]
ml_adk_dependency = [
- 'google-adk==1.28.1',
+ 'google-adk==1.32.0',
# proto-plus<1.24 caps protobuf<5; opentelemetry-proto (via ADK) needs
# protobuf>=5. Scoped here so the main dependency list stays broader.
'proto-plus>=1.26.1,<2',
- 'opentelemetry-api==1.37.0',
- 'opentelemetry-sdk==1.37.0',
- 'opentelemetry-exporter-otlp-proto-http==1.37.0',
+ 'opentelemetry-api==1.40.0',
+ 'opentelemetry-sdk==1.40.0',
+ 'opentelemetry-exporter-otlp-proto-http==1.40.0',
Review Comment:
The `opentelemetry` packages are pinned to `1.40.0` here, but the generated requirements files (e.g., in `sdks/python/container/ml/py310/base_image_requirements.txt`) have been updated to `1.41.1`. These versions should be aligned to prevent `pip` from attempting to downgrade the packages when installing the ML extras in the Beam containers.
```suggestion
'opentelemetry-api==1.41.1',
'opentelemetry-sdk==1.41.1',
'opentelemetry-exporter-otlp-proto-http==1.41.1',
```
##########
sdks/python/container/ml/py312/gpu_image_requirements.txt:
##########
@@ -269,44 +284,41 @@ sortedcontainers==2.4.0
soundfile==0.13.1
soupsieve==2.8.3
soxr==1.0.0
-SQLAlchemy==2.0.48
+SQLAlchemy==2.0.49
sqlalchemy_pytds==1.0.2
sqlparse==0.5.5
starlette==0.52.1
sympy==1.14.0
-tenacity==8.5.0
-tensorboard==2.20.0
-tensorboard-data-server==0.7.2
-tensorflow==2.20.0
-tensorflow-cpu-aws==2.20.0;platform_machine=="aarch64"
+tenacity==9.1.4
+tensorflow==2.21.0
+tensorflow-cpu-aws==2.21.0;platform_machine=="aarch64"
termcolor==3.3.0
-testcontainers==4.14.1
+testcontainers==4.14.2
threadpoolctl==3.6.0
tiktoken==0.12.0
tokenizers==0.21.4
-torch==2.8.0
+torch==2.7.1
Review Comment:
`torch` is being downgraded to `2.7.1` in the Python 3.12 GPU requirements, while the CPU version is at `2.8.0` and `setup.py` has been updated to allow versions up to `2.9.0`. This downgrade seems inconsistent with the overall goal of the PR to update versions.
```
torch==2.8.0
```
##########
sdks/python/container/ml/py312/gpu_image_requirements.txt:
##########
@@ -269,44 +284,41 @@ sortedcontainers==2.4.0
soundfile==0.13.1
soupsieve==2.8.3
soxr==1.0.0
-SQLAlchemy==2.0.48
+SQLAlchemy==2.0.49
sqlalchemy_pytds==1.0.2
sqlparse==0.5.5
starlette==0.52.1
sympy==1.14.0
-tenacity==8.5.0
-tensorboard==2.20.0
-tensorboard-data-server==0.7.2
-tensorflow==2.20.0
-tensorflow-cpu-aws==2.20.0;platform_machine=="aarch64"
+tenacity==9.1.4
+tensorflow==2.21.0
+tensorflow-cpu-aws==2.21.0;platform_machine=="aarch64"
termcolor==3.3.0
-testcontainers==4.14.1
+testcontainers==4.14.2
threadpoolctl==3.6.0
tiktoken==0.12.0
tokenizers==0.21.4
-torch==2.8.0
+torch==2.7.1
torchaudio==2.7.1
torchvision==0.22.1
tqdm==4.67.3
transformers==4.55.4
triton==3.3.1
-typer==0.24.1
+typer==0.25.1
typing-inspection==0.4.2
typing_extensions==4.15.0
-tzdata==2025.3
+tzdata==2026.2
uritemplate==4.2.0
urllib3==2.6.3
-uvicorn==0.41.0
+uvicorn==0.46.0
uvloop==0.22.1
virtualenv-clone==0.5.7
vllm==0.10.1.1
watchfiles==1.1.1
websockets==16.0
-Werkzeug==3.1.6
-wheel==0.46.3
+wheel==0.47.0
wrapt==2.1.2
xformers==0.0.31
-xgrammar==0.1.32
+xgrammar==0.1.21
Review Comment:
`xgrammar` is being downgraded from `0.1.32` to `0.1.21`. This appears to be a regression unless it was done to resolve a specific dependency conflict or build issue.
```
xgrammar==0.1.32
```
##########
sdks/python/setup.py:
##########
@@ -500,9 +500,10 @@ def get_portability_package_data():
'requests_mock>=1.7,<2.0',
# google-adk 1.28+ requires tenacity>=9,<10 (conflicts with <9).
'tenacity>=8.0.0,<10',
Review Comment:
The comment on line 501 indicates that `google-adk 1.28+` requires `tenacity>=9`. Since `google-adk` is being updated to `1.32.0` in this PR, the lower bound for `tenacity` should be updated to `9.0.0` to maintain consistency and avoid potential runtime conflicts.
```suggestion
'tenacity>=9.0.0,<10',
```
##########
sdks/python/container/ml/py310/base_image_requirements.txt:
##########
@@ -125,7 +125,7 @@ Js2Py==0.74
jsonpickle==3.4.2
jsonschema==4.26.0
jsonschema-specifications==2025.9.1
-keras==3.13.2
+keras==3.12.1
Review Comment:
`keras` is being downgraded to `3.12.1` for Python 3.10, whereas it is being upgraded to `3.14.0` for Python 3.11 through 3.13. Unless there is a specific compatibility issue necessitating this downgrade on Python 3.10, it should be aligned with the other versions.
```
keras==3.14.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38358:
URL: https://github.com/apache/beam/pull/38358#discussion_r3178555987
##########
sdks/python/setup.py:
##########
@@ -656,7 +657,7 @@ def get_portability_package_data():
],
'ml_cpu': [
'tensorflow>=2.12.0',
- 'torch==2.8.0+cpu',
+ 'torch==2.8.0',
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38358:
URL: https://github.com/apache/beam/pull/38358#issuecomment-4365412256
Assigning reviewers:
R: @jrmccluskey for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] regenerate requirements and tweak versions based on prior or proposed changes [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw closed pull request #38358: regenerate requirements and tweak versions based on prior or proposed changes
URL: https://github.com/apache/beam/pull/38358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org