You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by gn...@apache.org on 2012/07/25 11:52:34 UTC
svn commit: r1365507 -
/felix/trunk/framework/src/main/java/org/apache/felix/framework/StatefulResolver.java
Author: gnodet
Date: Wed Jul 25 09:52:33 2012
New Revision: 1365507
URL: http://svn.apache.org/viewvc?rev=1365507&view=rev
Log:
[FELIX-3609] Optimization: avoid unnecessary toString() computations
Modified:
felix/trunk/framework/src/main/java/org/apache/felix/framework/StatefulResolver.java
Modified: felix/trunk/framework/src/main/java/org/apache/felix/framework/StatefulResolver.java
URL: http://svn.apache.org/viewvc/felix/trunk/framework/src/main/java/org/apache/felix/framework/StatefulResolver.java?rev=1365507&r1=1365506&r2=1365507&view=diff
==============================================================================
--- felix/trunk/framework/src/main/java/org/apache/felix/framework/StatefulResolver.java (original)
+++ felix/trunk/framework/src/main/java/org/apache/felix/framework/StatefulResolver.java Wed Jul 25 09:52:33 2012
@@ -761,6 +761,8 @@ class StatefulResolver
private void markResolvedRevisions(Map<BundleRevision, List<ResolverWire>> wireMap)
throws ResolveException
{
+ boolean debugLog = m_felix.getLogger().getLogLevel() >= Logger.LOG_DEBUG;
+
// DO THIS IN THREE PASSES:
// 1. Aggregate fragments per host.
// 2. Attach wires and fragments to hosts.
@@ -841,13 +843,19 @@ class StatefulResolver
if (Util.isFragment(revision))
{
- m_felix.getLogger().log(
- Logger.LOG_DEBUG,
- "FRAGMENT WIRE: " + rw.toString());
+ if (debugLog)
+ {
+ m_felix.getLogger().log(
+ Logger.LOG_DEBUG,
+ "FRAGMENT WIRE: " + rw.toString());
+ }
}
else
{
- m_felix.getLogger().log(Logger.LOG_DEBUG, "WIRE: " + rw.toString());
+ if (debugLog)
+ {
+ m_felix.getLogger().log(Logger.LOG_DEBUG, "WIRE: " + rw.toString());
+ }
if (rw.getCapability().getNamespace()
.equals(BundleRevision.PACKAGE_NAMESPACE))