You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/28 19:24:42 UTC

[GitHub] [spark] zero323 commented on a change in pull request #29563: [SPARK-32719][PYTHON] Add Flake8 check missing imports

zero323 commented on a change in pull request #29563:
URL: https://github.com/apache/spark/pull/29563#discussion_r479493703



##########
File path: python/pyspark/sql/readwriter.py
##########
@@ -1225,7 +1226,6 @@ def overwrite(self, condition):
         Overwrite rows matching the given filter condition with the contents of the data frame in
         the output table.
         """
-        condition = _to_java_column(column)

Review comment:
       Indeed. Thanks for catching this @Fokko 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org