You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2020/04/29 03:00:37 UTC

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

ottobackwards commented on a change in pull request #42:
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041000



##########
File path: docker/README.md
##########
@@ -209,33 +140,21 @@ testing scripts to be added to a pull request, and subsequently to a test suite.
   ```bash
   --log-directory                [REQUIRED] The directory with the logs
   ```
-- `stop_container.sh`: Stops and removes a Docker container with a given name
-  ###### Parameters
-  ```bash
-  --container-name               [REQUIRED] The Docker container name
-  ```
 
 #### The example end to end test script
 
 `run_end_to_end.sh` is provided as an example of a testing script.  Specific or extended scripts can be created similar to this script to use the containers.
 This script does the following:
 

Review comment:
       should these all be #1?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org